[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] D11403: [Modules] Add Darwin-specific compatibility module map parsing hacks
From:       Ben Langmuir via cfe-commits <cfe-commits () lists ! llvm ! org>
Date:       2015-08-13 17:20:53
Message-ID: 82ea7bd6777ad37cce09adafafe36d81 () localhost ! localdomain
[Download RAW message or body]

benlangmuir closed this revision.
benlangmuir added a comment.

Any regression to code completion was below the noise level in my testing.

r244912


================
Comment at: include/clang/Basic/Module.h:363
@@ +362,3 @@
+  /// This is more efficient than getFullModuleName().
+  bool fullModuleNameEqual(ArrayRef<StringRef> nameParts) const;
+
----------------
rsmith wrote:
> `fullModuleNameEquals` (extra 's' at the end) or `fullModuleNameIs` maybe?
I like fullModuleNameIs.


Repository:
  rL LLVM

http://reviews.llvm.org/D11403



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[prev in list] [next in list] [prev in thread] [next in thread]