[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] D11658: [Sema] main can't be declared as global variable
From:       Richard Smith via cfe-commits <cfe-commits () lists ! llvm ! org>
Date:       2015-08-12 22:43:20
Message-ID: c46e5bf02b3b001ee93ccece3eef0169 () localhost ! localdomain
[Download RAW message or body]

rsmith added a comment.

Looks good other than the diagnostic wording.


================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:513
@@ -512,1 +512,3 @@
     "platform-specific data}0) must be of type %1">;
+def err_main_global_variable : Error<"main can't be declared as global variable">;
+def warn_main_redefined : Warning<"external-linkage variable named 'main' has "
----------------
It's much more common to use "cannot" rather than the contraction "can't" in our diagnostic wording.

================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:514
@@ +513,3 @@
+def err_main_global_variable : Error<"main can't be declared as global variable">;
+def warn_main_redefined : Warning<"external-linkage variable named 'main' has "
+    "undefined behavior">, InGroup<Main>;
----------------
I would still like this reworded.


http://reviews.llvm.org/D11658



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[prev in list] [next in list] [prev in thread] [next in thread]