[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] D11789: Modify DeclaratorChuck::getFunction to be passed an Exception Specification Sour
From:       Nathan Wilson via cfe-commits <cfe-commits () lists ! llvm ! org>
Date:       2015-08-07 2:09:53
Message-ID: 891cb604cce4eb6acaee2bfe5c764b12 () localhost ! localdomain
[Download RAW message or body]

nwilson added inline comments.

================
Comment at: lib/Sema/SemaDecl.cpp:7454-7456
@@ +7453,5 @@
+              PDiag(diag::err_function_concept_exception_spec);
+          if (Range.isValid()) {
+            PD << FixItHint::CreateRemoval(Range);
+          }
+          Diag(NewFD->getLocation(), PD);
----------------
rsmith wrote:
> You don't need this `if`; a `FixItHint` with an invalid range has no effect.
Ahhh, okay. I misunderstood the original comment about an empty SourceRange apparently.

I'll go back to using Diagnostic rather than PartialDiagnostic as well.




http://reviews.llvm.org/D11789



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[prev in list] [next in list] [prev in thread] [next in thread]