From cfe-commits Wed Aug 05 21:45:08 2015 From: Richard Smith Date: Wed, 05 Aug 2015 21:45:08 +0000 To: cfe-commits Subject: Re: [PATCH] D11403: [Modules] Add Darwin-specific compatibility module map parsing hacks Message-Id: X-MARC-Message: https://marc.info/?l=cfe-commits&m=143881111530401 cnNtaXRoIGFkZGVkIGlubGluZSBjb21tZW50cy4KCj09PT09PT09PT09PT09PT0KQ29tbWVudCBh dDogbGliL0xleC9Nb2R1bGVNYXAuY3BwOjE4OTEtMTkwOApAQCArMTg5MCwyMCBAQAorCisgIGlm IChBY3RpdmVNb2R1bGUtPlVzZXNSZXF1aXJlc0V4Y2x1ZGVkSGFjaykgeworICAgIC8vIE1hcmsg dGhpcyBoZWFkZXIgJ3RleHR1YWwnIChzZWUgZG9jIGNvbW1lbnQgZm9yCisgICAgLy8gTW9kdWxl OjpVc2VzUmVxdWlyZXNFeGNsdWRlZEhhY2spLiBBbHRob3VnaCBpdGVyYXRpbmcgb3ZlciB0aGUg ZGlyZWN0b3J5CisgICAgLy8gaXMgcmVsYXRpdmVseSBleHBlbnNpdmUsIGluIHByYWN0aWNlIHRo aXMgb25seSBhcHBsaWVzIHRvIHRoZSB1bmNvbW1vbmx5CisgICAgLy8gdXNlZCBUY2wgbW9kdWxl IG9uIERhcndpbiBwbGF0Zm9ybXMuCisgICAgc3RkOjplcnJvcl9jb2RlIEVDOworICAgIGZvciAo bGx2bTo6c3lzOjpmczo6cmVjdXJzaXZlX2RpcmVjdG9yeV9pdGVyYXRvciBJKERpci0+Z2V0TmFt ZSgpLCBFQyksIEU7CisgICAgICAgICBJICE9IEUgJiYgIUVDOyBJLmluY3JlbWVudChFQykpIHsK KyAgICAgIGlmIChjb25zdCBGaWxlRW50cnkgKkZFID0gU291cmNlTWdyLmdldEZpbGVNYW5hZ2Vy KCkuZ2V0RmlsZShJLT5wYXRoKCkpKSB7CisgICAgICAgIC8vIEZJWE1FOiBUYWtpbmcgdGhlIG5h bWUgZnJvbSB0aGUgRmlsZUVudHJ5IGlzIHVuc3RhYmxlIGFuZCBjYW4gZ2l2ZQorICAgICAgICAv LyBkaWZmZXJlbnQgcmVzdWx0cyBkZXBlbmRpbmcgb24gaG93IHdlJ3ZlIHByZXZpb3VzbHkgbmFt ZWQgdGhhdCBmaWxlCisgICAgICAgIC8vIGluIHRoaXMgYnVpbGQuCisgICAgICAgIE1vZHVsZTo6 SGVhZGVyIEhlYWRlciA9IHtGRS0+Z2V0TmFtZSgpLCBGRX07CisgICAgICAgIE1hcC5hZGRIZWFk ZXIoQWN0aXZlTW9kdWxlLCBIZWFkZXIsIE1vZHVsZU1hcDo6VGV4dHVhbEhlYWRlcik7CisgICAg ICB9CisgICAgfQorICAgIHJldHVybjsKKyAgfQorCi0tLS0tLS0tLS0tLS0tLS0KYmVubGFuZ211 aXIgd3JvdGU6Cj4gcnNtaXRoIHdyb3RlOgo+ID4gSXMgdGhlcmUgYSBiZXR0ZXIgd2F5IG9mIGhh bmRsaW5nIHRoaXM/IElmIHRoZSBwYXJlbnQgZGlyZWN0b3J5IGlzbid0IGl0c2VsZiBhbiB1bWJy ZWxsYSBkaXJlY3Rvcnkgb2Ygc29tZSBtb2R1bGUsIG1heWJlIHlvdSBjb3VsZCBqdXN0IGlnbm9y ZSB0aGUgdW1icmVsbGEgZGlyZWN0b3J5IGRlY2xhcmF0aW9uIGZvciB0aGlzIG1vZHVsZSBlbnRp cmVseT8KPiBUaGlzIG9ubHkgYWZmZWN0cyBUY2wuUHJpdmF0ZSwgYW5kIFRjbCBoYXMgYW4gdW1i cmVsbGEgaGVhZGVyIHNvIEkgZG9uJ3QgdGhpbmsgdGhhdCB3aWxsIHdvcmsuICBUaGUgb25seSBv dGhlciB3YXkgSSBjYW4gdGhpbmsgb2YgbWFraW5nIHRoaXMgd29yayBpcyB0byBoYXZlIGEgbm90 aW9uIG9mIGEgKmRpcmVjdG9yeSogdGhhdCBpcyBleGVtcHQgZnJvbSBpdHMgY29udGFpbmluZyB1 bWJyZWxsYSwgYnV0IEknbSBub3Qgc3VyZSB0aGF0J3MgYSBnZW5lcmFsbHkgZ29vZCBmZWF0dXJl IGFuZCBpdCBzZWVtcyBsaWtlIGEgbG90IG1vcmUgd29yay4gIExldCBtZSBrbm93IGlmIHlvdSBo YXZlIGFueSBzdWdnZXN0aW9ucyB0aG91Z2guClVnaCwgT0suIEluIHRoYXQgY2FzZToKCiAqIG1h eWJlIHRha2UgdGhlIGZpbGUgbmFtZSBmcm9tIGBJLT5wYXRoKClgIHJhdGhlciB0aGFuIGBGRS0+ Z2V0TmFtZSgpYCAod2Ugd2FudCB0byBpbWFnaW5lIHRoZSBmaWxlcyB3ZXJlIG5hbWVkIHdpdGhp biB0aGUgdW1icmVsbGEgZGlyZWN0b3J5IHJhdGhlciB0aGFuIHNvbWUgb3RoZXIgd2F5KQogKiBz b3J0IHRoZSBwYXRocyBiZWZvcmUgeW91IGFkZCB0aGVtIHNvIHRoYXQgdGhlIHNlcmlhbGl6ZWQg cGNtIGRvZXNuJ3QgZGVwZW5kIG9uIGZpbGUgc3lzdGVtIHRyYXZlcnNhbCBvcmRlcgoKQWxzbywg eW91J2xsIGJlIHBheWluZyB0aGlzIGZpbGUgc3lzdGVtIHRyYXZlcnNhbCBjb3N0IHdoZW5ldmVy IHRoZSByZWxldmFudCBtb2R1bGUgbWFwIGlzIHBhcnNlZCwgbm90IG9ubHkgd2hlbiB0aGUgVGNs IG1vZHVsZSBpcyB1c2VkIC0tIGFuZCBpZiBpdCdzIHRoZSAvdXNyL2luY2x1ZGUgbW9kdWxlIG1h cCwgeW91J2xsIHdhbGsgdGhpcyB1bWJyZWxsYSBkaXJlY3Rvcnkgb24gZXZlcnkgYnVpbGQuIEp1 c3Qgd2FudGVkIHRvIGNvbmZpcm0geW91J3JlIE9LIHdpdGggdGhhdC4KCgpSZXBvc2l0b3J5Ogog IHJMIExMVk0KCmh0dHA6Ly9yZXZpZXdzLmxsdm0ub3JnL0QxMTQwMwoKCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpjZmUtY29tbWl0cyBtYWlsaW5nIGxp c3QKY2ZlLWNvbW1pdHNAbGlzdHMubGx2bS5vcmcKaHR0cDovL2xpc3RzLmxsdm0ub3JnL2NnaS1i aW4vbWFpbG1hbi9saXN0aW5mby9jZmUtY29tbWl0cwo=