[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] D11757: Propagate SourceLocations through to get a Loc on float_cast_overflow
From:       Richard Smith <richard () metafoo ! co ! uk>
Date:       2015-08-05 21:38:05
Message-ID: a6bb0b98ba69c3e7c4b08b5b176ff13c () localhost ! localdomain
[Download RAW message or body]

rsmith added a comment.

Looks good to me too (though please hold off on this until you and samsonov have \
agreed on what to do about the ubsan ABI change).


================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1288
@@ -1287,3 +1287,3 @@
                        OpenMPDirectiveKind Kind,
-                       const RegionCodeGenTy &BodyOpGen) {
+                       const RegionCodeGenTy &BodyOpGen, SourceLocation Loc) {
   llvm::Value *CallBool = CGF.EmitScalarConversion(
----------------
Please reorder the parameters to put the source location before the body, so that the \
expected lambda parameter is last (see \
http://llvm.org/docs/CodingStandards.html#format-lambdas-like-blocks-of-code).


http://reviews.llvm.org/D11757



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]