[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] D11757: Propagate SourceLocations through to get a Loc on float_cast_overflow
From:       Alexey Samsonov <vonosmas () gmail ! com>
Date:       2015-08-05 19:42:15
Message-ID: 7395e7d341a42eb690b14c97c1dfd62c () localhost ! localdomain
[Download RAW message or body]

samsonov added a comment.

Thank you for working on this! This change looks good to me, but I'll let Richard say a final \
word.

Note that you would need to make a corresponding change in UBSan compiler-rt runtime. Also, \
this is an ABI-breaking change - e.g. shared objects built with older Clang will not work \
properly with new runtime. I would recommend you to add *some* diagnostic to ubsan runtime - \
e.g. if it tries to read SourceLocation from FloatCastOverflowData passed to handler, but it \
looks more like TypeDescriptor, than it would crash with a verbose message.


http://reviews.llvm.org/D11757



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]