'Re: [PATCH] D11403: [Modules] Add Darwin-specific compatibility module map parsing hacks'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] D11403: [Modules] Add Darwin-specific compatibility module map parsing hacks
From:       Sean Silva <chisophugis () gmail ! com>
Date:       2015-08-04 4:04:56
Message-ID: CAHnXoa=jk90q74xrmOsBuVYj0C6QfxyBMErceXSnSbm7su404g () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

Ping.

On Wed, Jul 22, 2015 at 8:52 PM, Sean Silva <chisophugis@gmail.com> wrote:

> silvas added a comment.
>
> My gut is that this seems too complicated, but on the other hand I don't
> have a suggestion for simplifying it. I'll let Richard decide on what is an
> acceptable level of complexity.
>
> Could you put a lengthy comment somewhere describing exactly which
> shipping module map files are affected by this, and the range of affected
> SDK versions (hopefully this will be fixed in the next release?)?
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D11403
>
>
>
>

[Attachment #5 (text/html)]

<div dir="ltr">Ping.</div><div class="gmail_extra"><br><div class="gmail_quote">On \
Wed, Jul 22, 2015 at 8:52 PM, Sean Silva <span dir="ltr">&lt;<a \
href="mailto:chisophugis@gmail.com" \
target="_blank">chisophugis@gmail.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">silvas added a comment.<br> <br>
My gut is that this seems too complicated, but on the other hand I don&#39;t have a \
suggestion for simplifying it. I&#39;ll let Richard decide on what is an acceptable \
level of complexity.<br> <br>
Could you put a lengthy comment somewhere describing exactly which shipping module \
map files are affected by this, and the range of affected SDK versions (hopefully \
this will be fixed in the next release?)?<br> <div class="HOEnZb"><div \
class="h5"><br> <br>
Repository:<br>
   rL LLVM<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11403&d \
=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=wRWqs \
G3Bt38pT_3EQmURCqTmeJt0T2X1pTHbkBkIRvo&s=UCcJx0eUzIyqnBtsFYlzQSCXyLjQ9E4YE56jb38-Y8o&e=" \
rel="noreferrer" target="_blank">http://reviews.llvm.org/D11403</a><br> <br>
<br>
<br>
</div></div></blockquote></div><br></div>

_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

[prev in list] [next in list] [prev in thread] [next in thread] 