From cfe-commits Mon Aug 03 19:23:31 2015 From: Richard Smith Date: Mon, 03 Aug 2015 19:23:31 +0000 To: cfe-commits Subject: Re: [PATCH] D11194: Instantiate function declarations in instantiated functions. Message-Id: X-MARC-Message: https://marc.info/?l=cfe-commits&m=143863042713204 rsmith added inline comments. ================ Comment at: lib/AST/DeclBase.cpp:269-271 @@ -268,1 +268,5 @@ +bool Decl::isLexicallyWithinFunctionOrMethod() const { + return getLexicalDeclContext()->isFunctionOrMethod(); +} + ---------------- This should also return true if the lexical decl context is a local class. The point is to allow you to remove the code duplication you added in the other changes in this patch. http://reviews.llvm.org/D11194 _______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits