From cfe-commits Thu Jul 30 14:07:27 2015 From: Ulrich Weigand Date: Thu, 30 Jul 2015 14:07:27 +0000 To: cfe-commits Subject: Re: [PATCH] D11001: Add support for System z vector language extensions Message-Id: X-MARC-Message: https://marc.info/?l=cfe-commits&m=143826571012046 uweigand marked an inline comment as done. uweigand added a comment. In http://reviews.llvm.org/D11001#214817, @rsmith wrote: > LGTM, sorry for the delay. Please remove the `-mzvector` flag if we don't actually need it for GCC compatibility. Thanks for the review! We do in fact need the `-mzvector` flag for GCC compatibility, see below. ================ Comment at: include/clang/Driver/Options.td:1330-1333 @@ -1329,1 +1329,6 @@ +def fzvector : Flag<["-"], "fzvector">, Group, Flags<[CC1Option]>, + HelpText<"Enable System z vector language extension">; +def fno_zvector : Flag<["-"], "fno-zvector">, Group, + Flags<[CC1Option]>; +def mzvector : Flag<["-"], "mzvector">, Alias; ---------------- rsmith wrote: > Does GCC really support `-mzvector`? I can't find any reference to such a flag, and grepping the GCC sources finds no occurrences of the string "zvector" at all. The flag is implemented here in the GCC sources: https://gcc.gnu.org/viewcvs/gcc/trunk/gcc/config/s390/s390.opt?revision=223398&view=markup ``` mzvector Target Report Mask(ZVECTOR) Enable the z vector language extension providing the context-sensitive vector macro. ``` (You're right that this flag currently does not show up in the GCC documentation. That was an oversight. I've asked Andreas to fix this.) ================ Comment at: include/clang/Parse/Parser.h:115 @@ -116,1 +114,3 @@ IdentifierInfo *Ident_bool; + /// Ident_pixel - cached cached IdentifierInfos for "pixel" fast comparison. + /// Only present if AltiVec enabled. ---------------- rsmith wrote: > Too many "cached"s Fixed. http://reviews.llvm.org/D11001 _______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits