[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] D11490: [Concepts] Add diagnostic: non template declaration
From:       Nathan Wilson <nwilson20 () gmail ! com>
Date:       2015-07-30 2:22:29
Message-ID: CAMDJ-qbF_wv=c2hPY4bCm5CYRhrkCgOphTwo-ZpPiHCG04RC3A () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Thanks Richard.

Sorry about the failed test that Hubert brought up. I'll remove that if no
one objects since it's covered by the Sema tests in this Patch.

Potentially that test in the Parser could be modified to be:
template<typename T>
concept D1 = true;

However, it will just pass and I believe it needs a diagnostic for the
return type not being bool.


On Wed, Jul 29, 2015 at 6:40 PM, Richard Smith <richard@metafoo.co.uk>
wrote:

> rsmith accepted this revision.
> rsmith added a comment.
> This revision is now accepted and ready to land.
>
> LGTM
>
>
> http://reviews.llvm.org/D11490
>
>
>
>

[Attachment #5 (text/html)]

<div dir="ltr">Thanks Richard.<div><br></div><div>Sorry about the failed test that \
Hubert brought up. I&#39;ll remove that if no one objects since it&#39;s covered by \
the Sema tests in this Patch.</div><div><br></div><div>Potentially that test in the \
Parser could be modified to be:</div><div>template&lt;typename \
T&gt;</div><div>concept D1 = true;</div><div><br></div><div>However, it will just \
pass and I believe it needs a diagnostic for the return type not being \
bool.</div><div>  </div></div><div class="gmail_extra"><br><div \
class="gmail_quote">On Wed, Jul 29, 2015 at 6:40 PM, Richard Smith <span \
dir="ltr">&lt;<a href="mailto:richard@metafoo.co.uk" \
target="_blank">richard@metafoo.co.uk</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">rsmith accepted this revision.<br> rsmith added a \
comment.<br> This revision is now accepted and ready to land.<br>
<br>
LGTM<br>
<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11490&d \
=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=Ljx7k \
nGZeVGa430MpZx7b-YeGT0f6kHoH55CHNkwZGU&s=6XNZkUb59iavjDmjMzpjFaTBdt-aSislU1poUckuQ1c&e=" \
rel="noreferrer" target="_blank">http://reviews.llvm.org/D11490</a><br> <br>
<br>
<br>
</blockquote></div><br></div>



_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]