[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] D11001: Add support for System z vector language extensions
From:       Richard Smith <richard () metafoo ! co ! uk>
Date:       2015-07-30 1:37:01
Message-ID: 53ec612eeb627c5afb9f72fbbb59f48f () localhost ! localdomain
[Download RAW message or body]

rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

LGTM, sorry for the delay. Please remove the `-mzvector` flag if we don't \
actually need it for GCC compatibility.


================
Comment at: include/clang/Driver/Options.td:1330-1333
@@ -1329,1 +1329,6 @@
 
+def fzvector : Flag<["-"], "fzvector">, Group<f_Group>, \
Flags<[CC1Option]>, +  HelpText<"Enable System z vector language \
extension">; +def fno_zvector : Flag<["-"], "fno-zvector">, Group<f_Group>,
+  Flags<[CC1Option]>;
+def mzvector : Flag<["-"], "mzvector">, Alias<fzvector>;
----------------
Does GCC really support `-mzvector`? I can't find any reference to such a \
flag, and grepping the GCC sources finds no occurrences of the string \
"zvector" at all.

================
Comment at: include/clang/Parse/Parser.h:115
@@ -116,1 +114,3 @@
   IdentifierInfo *Ident_bool;
+  /// Ident_pixel - cached cached IdentifierInfos for "pixel" fast \
comparison. +  /// Only present if AltiVec enabled.
----------------
Too many "cached"s


http://reviews.llvm.org/D11001




_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]