[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: Patches for 3.7 and move warnings
From:       Richard Trieu <rtrieu () google ! com>
Date:       2015-07-29 23:48:21
Message-ID: CAPUYKWkZZLRX-rxy2zwMX0wC6viHRQhQEX7dxDQqa8pTp9yBVg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


The follow-up change is r243594.

On Wed, Jul 29, 2015 at 4:45 PM, Richard Smith <richard@metafoo.co.uk>
wrote:

> On Wed, Jul 29, 2015 at 10:20 AM, Hans Wennborg <hwennborg@google.com>
> wrote:
>
>> Yes.
>>
>> Richard Smith: approved for the branch?
>
>
> First and third LGTM for branch. r243463 has a pending follow-up change,
> and we should take neither or both (preferably both).
>
> On Wed, Jul 29, 2015 at 10:13 AM, Richard Trieu <rtrieu@google.com> wrote:
>> > Hans,
>> >
>> > These are patches to fix -Wpessimizing-move and -Wredundant-move
>> warnings.
>> > Is it still possible to get these into the 3.7 branch?
>> >
>> > Richard
>> >
>> > Revisions:
>> > r242600
>> > r243463
>> > r243538
>> >
>> > Links:
>> > http://llvm.org/viewvc/llvm-project?view=revision&revision=242600
>> > http://llvm.org/viewvc/llvm-project?view=revision&revision=243463
>> > http://llvm.org/viewvc/llvm-project?view=revision&revision=243538
>>
>
>

[Attachment #5 (text/html)]

<div dir="ltr">The follow-up change is r243594.<br><div class="gmail_extra"><br><div \
class="gmail_quote">On Wed, Jul 29, 2015 at 4:45 PM, Richard Smith <span \
dir="ltr">&lt;<a href="mailto:richard@metafoo.co.uk" \
target="_blank">richard@metafoo.co.uk</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div \
class="gmail_quote"><span class="">On Wed, Jul 29, 2015 at 10:20 AM, Hans Wennborg \
<span dir="ltr">&lt;<a href="mailto:hwennborg@google.com" \
target="_blank">hwennborg@google.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Yes.<br> <br>
Richard Smith: approved for the branch?</blockquote><div><br></div></span><div>First \
and third LGTM for branch. r243463 has a pending follow-up change, and we should take \
neither or both (preferably both).</div><div><br></div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><span><span class=""> On Wed, Jul 29, 2015 at 10:13 AM, \
Richard Trieu &lt;<a href="mailto:rtrieu@google.com" \
target="_blank">rtrieu@google.com</a>&gt; wrote:<br> &gt; Hans,<br>
&gt;<br>
&gt; These are patches to fix -Wpessimizing-move and -Wredundant-move warnings.<br>
&gt; Is it still possible to get these into the 3.7 branch?<br>
&gt;<br>
&gt; Richard<br>
&gt;<br>
&gt; Revisions:<br>
&gt; r242600<br>
&gt; r243463<br>
&gt; r243538<br>
&gt;<br>
&gt; Links:<br></span>
&gt; <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm \
-2Dproject-3Fview-3Drevision-26revision-3D242600&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=B \
SqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=dTR9hR-RlkvqSW45DlD4yLeKZc3nKAsQLLg9rjj3xsU&s=-VeifZyWBKKufXIPTe4aYQmwz0JHHnM4U-08WsmNO4I&e=" \
rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?view=revision&amp;revision=242600</a><br>
 </span><span class="">&gt; <a \
href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproje \
ct-3Fview-3Drevision-26revision-3D243463&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvK \
MW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=dTR9hR-RlkvqSW45DlD4yLeKZc3nKAsQLLg9rjj3xsU&s=SrikL1QUeq1L17w1SfYmbhCrj1pRM1iTFUSqjyKHxZM&e=" \
rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?view=revision&amp;revision=243463</a><br>
 &gt; <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llv \
m-2Dproject-3Fview-3Drevision-26revision-3D243538&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r= \
BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=dTR9hR-RlkvqSW45DlD4yLeKZc3nKAsQLLg9rjj3xsU&s=9s5WlEAkF_OJgKkO2gyR3bDQ5XVPB6szfNFlT6XwP78&e=" \
rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?view=revision&amp;revision=243538</a><br>
 </span></blockquote></div><br></div></div>
</blockquote></div><br></div></div>



_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]