[prev in list] [next in list] [prev in thread] [next in thread]
List: cfe-commits
Subject: Re: [libunwind] Proposal to merge patches for libc++abi to 3.7
From: Saleem Abdulrasool <compnerd () compnerd ! org>
Date: 2015-07-29 1:31:03
Message-ID: CANXyDxsRshv+rF0LpJW1CpxXwRnYUK+ziF4kH2Ou9dXQbRe=ZA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Tue, Jul 28, 2015 at 9:23 AM, Hans Wennborg <hans@chromium.org> wrote:
> On Mon, Jul 27, 2015 at 7:38 PM, Saleem Abdulrasool
> <compnerd@compnerd.org> wrote:
> > On Mon, Jul 27, 2015 at 6:36 PM, Hans Wennborg <hans@chromium.org>
> wrote:
> >>
> >> Nick, Saleem: are these OK for merging to 3.7?
> >
> >
> > Yes, I believe that these two are safe and needed for the 3.7 release.
>
> Thanks everyone. Merged in r243436 and r243437, respectively.
>
>
Thanks for merging these!
> - Hans
>
> >> On Mon, Jul 27, 2015 at 4:55 PM, Logan Chien <tzuhsiang.chien@gmail.com
> >
> >> wrote:
> >> > Hi,
> >> >
> >> >> Do we have a code owner for libunwind?
> >> > It seems not.
> >> > FYR, I remembered that kledzik@ contributed the initial code base to
> >> > libc++abi. compnerd@ extracted libunwind from libc++abi.
> >> >
> >> >> These commits don't seem to have reached cfe-commits. Does anyone
> know
> >> >> why?
> >> > I feel that this is related to the site configuration. I observed
> this
> >> > after the spin-off of libunwind.
> >> >
> >> >> Should r243147 also be merged?
> >> > Yes. It will be a good to do so as well.
> >> >
> >> > Sincerely,
> >> > Logan
> >> >
> >> > On Tue, Jul 28, 2015 at 2:12 AM, Hans Wennborg <hans@chromium.org>
> >> > wrote:
> >> >>
> >> >> Sounds reasonable. I'm happy to merge, but also have a few questions:
> >> >>
> >> >> Do we have a code owner for libunwind?
> >> >>
> >> >> These commits don't seem to have reached cfe-commits. Does anyone
> know
> >> >> why?
> >> >>
> >> >> Should r243147 also be merged?
> >> >>
> >> >> Thanks,
> >> >> Hans
> >> >>
> >> >> On Sun, Jul 26, 2015 at 1:46 PM, Chandler Carruth
> >> >> <chandlerc@google.com>
> >> >> wrote:
> >> >> > FWIW, I agree, this seems really important.
> >> >> >
> >> >> > On Sun, Jul 26, 2015 at 8:54 AM Logan Chien
> >> >> > <tzuhsiang.chien@gmail.com>
> >> >> > wrote:
> >> >> >>
> >> >> >> Hi Hans and Nick,
> >> >> >>
> >> >> >> I would like to propose to merge following patches to libunwind
> 3.7
> >> >> >> branch:
> >> >> >>
> >> >> >> r242642: libunwind: Introduce __libunwind_config.h.
> >> >> >> r243073: unwind: Fix libc++abi and libgcc build.
> >> >> >>
> >> >> >> We need these changes to build libc++abi with libgcc (without
> >> >> >> libunwind.so.) IMO, this is an important fix that should be
> merged
> >> >> >> to
> >> >> >> 3.7
> >> >> >> release.
> >> >> >>
> >> >> >> May you have a look? Thanks for your help!
> >> >> >>
> >> >> >> Sincerely,
> >> >> >> Logan
>
--
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
[Attachment #5 (text/html)]
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Jul 28, 2015 \
at 9:23 AM, Hans Wennborg <span dir="ltr"><<a href="mailto:hans@chromium.org" \
target="_blank">hans@chromium.org</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">On Mon, Jul 27, 2015 at 7:38 PM, Saleem Abdulrasool<br> \
<<a href="mailto:compnerd@compnerd.org">compnerd@compnerd.org</a>> wrote:<br> \
<span class="">> On Mon, Jul 27, 2015 at 6:36 PM, Hans Wennborg <<a \
href="mailto:hans@chromium.org">hans@chromium.org</a>> wrote:<br> >><br>
>> Nick, Saleem: are these OK for merging to 3.7?<br>
><br>
><br>
> Yes, I believe that these two are safe and needed for the 3.7 release.<br>
<br>
</span>Thanks everyone. Merged in r243436 and r243437, respectively.<br>
<br></blockquote><div><br></div><div>Thanks for merging these!</div><div> \
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
- Hans<br>
<br>
>> On Mon, Jul 27, 2015 at 4:55 PM, Logan Chien <<a \
href="mailto:tzuhsiang.chien@gmail.com">tzuhsiang.chien@gmail.com</a>><br> <span \
class="">>> wrote:<br> >> > Hi,<br>
>> ><br>
>> >> Do we have a code owner for libunwind?<br>
>> > It seems not.<br>
>> > FYR, I remembered that kledzik@ contributed the initial code base \
to<br> >> > libc++abi. compnerd@ extracted libunwind from libc++abi.<br>
>> ><br>
>> >> These commits don't seem to have reached cfe-commits. Does \
anyone know<br> >> >> why?<br>
>> > I feel that this is related to the site configuration. I observed \
this<br> >> > after the spin-off of libunwind.<br>
>> ><br>
>> >> Should r243147 also be merged?<br>
>> > Yes. It will be a good to do so as well.<br>
>> ><br>
>> > Sincerely,<br>
>> > Logan<br>
>> ><br>
</span>>> > On Tue, Jul 28, 2015 at 2:12 AM, Hans Wennborg <<a \
href="mailto:hans@chromium.org">hans@chromium.org</a>><br> <span class="im \
HOEnZb">>> > wrote:<br> >> >><br>
>> >> Sounds reasonable. I'm happy to merge, but also have a few \
questions:<br> >> >><br>
>> >> Do we have a code owner for libunwind?<br>
>> >><br>
>> >> These commits don't seem to have reached cfe-commits. Does \
anyone know<br> >> >> why?<br>
>> >><br>
>> >> Should r243147 also be merged?<br>
>> >><br>
>> >> Thanks,<br>
>> >> Hans<br>
>> >><br>
>> >> On Sun, Jul 26, 2015 at 1:46 PM, Chandler Carruth<br>
</span><span class="im HOEnZb">>> >> <<a \
href="mailto:chandlerc@google.com">chandlerc@google.com</a>><br> >> >> \
wrote:<br> >> >> > FWIW, I agree, this seems really important.<br>
>> >> ><br>
>> >> > On Sun, Jul 26, 2015 at 8:54 AM Logan Chien<br>
</span><div class="HOEnZb"><div class="h5">>> >> > <<a \
href="mailto:tzuhsiang.chien@gmail.com">tzuhsiang.chien@gmail.com</a>><br> \
>> >> > wrote:<br> >> >> >><br>
>> >> >> Hi Hans and Nick,<br>
>> >> >><br>
>> >> >> I would like to propose to merge following patches to \
libunwind 3.7<br> >> >> >> branch:<br>
>> >> >><br>
>> >> >> r242642: libunwind: Introduce __libunwind_config.h.<br>
>> >> >> r243073: unwind: Fix libc++abi and libgcc build.<br>
>> >> >><br>
>> >> >> We need these changes to build libc++abi with libgcc \
(without<br> >> >> >> libunwind.so.) IMO, this is an important \
fix that should be merged<br> >> >> >> to<br>
>> >> >> 3.7<br>
>> >> >> release.<br>
>> >> >><br>
>> >> >> May you have a look? Thanks for your help!<br>
>> >> >><br>
>> >> >> Sincerely,<br>
>> >> >> Logan<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div \
class="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div> \
</div></div>
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic