[prev in list] [next in list] [prev in thread] [next in thread]
List: cfe-commits
Subject: Re: [PATCH] D11490: [Concepts] Add diagnostic: non template declaration
From: Hubert Tong <hubert.reinterpretcast () gmail ! com>
Date: 2015-07-24 19:43:09
Message-ID: CACvkUqZC+rsE6VhYdBQMRGfchcpueFLYz7GKtaw+=yHzuksDJw () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Thanks Aaron for copying the similar messages here. I'd still like the use
"definition of", but with Aaron's suggestion as the base.
I considered using plural nouns instead of singular ones to match the
existing messages better, but the result was clunky.
"'concept' can only appear on the definition of a function template or
variable template"
On Fri, Jul 24, 2015 at 3:37 PM, Aaron Ballman <aaron@aaronballman.com>
wrote:
> On Fri, Jul 24, 2015 at 3:27 PM, Nathan Wilson <nwilson20@gmail.com>
> wrote:
> >
> >
> > On Fri, Jul 24, 2015 at 2:14 PM, Aaron Ballman <aaron@aaronballman.com>
> > wrote:
> >>
> >> On Fri, Jul 24, 2015 at 2:43 PM, Nathan Wilson <nwilson20@gmail.com>
> >> wrote:
> >> > nwilson created this revision.
> >> > nwilson added reviewers: rsmith, faisalv, fraggamuffin,
> >> > hubert.reinterpretcast.
> >> > nwilson added a subscriber: cfe-commits.
> >> >
> >> > Adding diagnostic for concepts declared as non template (function or
> >> > variable)
> >> >
> >> > http://reviews.llvm.org/D11490
> >>
> >> >
> >> > Files:
> >> > include/clang/Basic/DiagnosticSemaKinds.td
> >> > lib/Sema/SemaDecl.cpp
> >> > test/SemaCXX/cxx-concept-declaration.cpp
> >> >
> >> > Index: test/SemaCXX/cxx-concept-declaration.cpp
> >> > ===================================================================
> >> > --- test/SemaCXX/cxx-concept-declaration.cpp
> >> > +++ test/SemaCXX/cxx-concept-declaration.cpp
> >> > @@ -15,3 +15,7 @@
> >> > struct C {
> >> > template<typename T> static concept bool D3 = true; //
> expected-error
> >> > {{concept declarations may only appear in namespace scope}}
> >> > };
> >> > +
> >> > +concept bool D4() { return true; } // expected-error {{concept can
> only
> >> > be applied to a function or variable template definition}}
> >> > +
> >> > +concept bool D5 = true; // expected-error {{concept can only be
> applied
> >> > to a function or variable template definition}}
> >> > Index: lib/Sema/SemaDecl.cpp
> >> > ===================================================================
> >> > --- lib/Sema/SemaDecl.cpp
> >> > +++ lib/Sema/SemaDecl.cpp
> >> > @@ -4865,6 +4865,12 @@
> >> > // C++ Concepts TS [dcl.spec.concept]p1: The concept specifier
> >> > shall be
> >> > // applied only to the definition of a function template or
> >> > variable
> >> > // template, declared in namespace scope
> >> > + if (!TemplateParamLists.size()) {
> >> > + Diag(D.getDeclSpec().getConceptSpecLoc(),
> >> > + diag::err_concept_decl_non_template);
> >> > + return nullptr;
> >> > + }
> >> > +
> >> > if (!DC->getRedeclContext()->isFileContext()) {
> >> > Diag(D.getIdentifierLoc(),
> >> >
> diag::err_concept_decls_may_only_appear_in_namespace_scope);
> >> > Index: include/clang/Basic/DiagnosticSemaKinds.td
> >> > ===================================================================
> >> > --- include/clang/Basic/DiagnosticSemaKinds.td
> >> > +++ include/clang/Basic/DiagnosticSemaKinds.td
> >> > @@ -1966,6 +1966,8 @@
> >> > "use __attribute__((visibility(\"hidden\"))) attribute instead">;
> >> >
> >> > // C++ Concepts TS
> >> > +def err_concept_decl_non_template : Error<
> >> > + "concept can only be applied to a function or variable template
> >> > definition">;
> >>
> >> Since we are using "concept" as a grammar term, I think we want to
> >> quote it. Similar diagnostics suggest phrasing like:
> >>
> >> "'concept' can only appear on a function template or variable template
> >> definition"
> >>
> >> This also reduces some ambiguity over how "function or variable
> template"
> >> binds.
> >>
> >> ~Aaron
> >
> >
> > May we apply both this suggestion and Hubert's? So it would be:
> >
> > "the 'concept' specifier may only be applied to the definition of a
> function
> > or variable template"
>
> I don't have a strong preference, but I think "specifier may only be"
> is kind of wordy without adding much value. For comparison:
>
> def err_inline_non_function : Error<
> "'inline' can only appear on functions">;
> def err_noreturn_non_function : Error<
> "'_Noreturn' can only appear on functions">;
> def err_virtual_non_function : Error<
> "'virtual' can only appear on non-static member functions">;
> def err_explicit_non_function : Error<
> "'explicit' can only appear on non-static member functions">;
>
> ~Aaron
>
> >
> >>
> >>
> >> > def err_concept_decls_may_only_appear_in_namespace_scope : Error<
> >> > "concept declarations may only appear in namespace scope">;
> >> > def err_function_concept_not_defined : Error<
> >> >
> >> >
> >> >
> >> > _______________________________________________
> >> > cfe-commits mailing list
> >> > cfe-commits@cs.uiuc.edu
> >> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >> >
> >
> >
>
[Attachment #5 (text/html)]
<div dir="ltr"><div>Thanks Aaron for copying the similar messages here. I'd still \
like the use "definition of", but with Aaron's suggestion as the \
base.<br></div>I considered using plural nouns instead of singular ones to match the \
existing messages better, but the result was \
clunky.<br><div><br>"'concept' can only appear on the definition of a \
function template or variable template"<br></div></div><div \
class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 24, 2015 at 3:37 PM, \
Aaron Ballman <span dir="ltr"><<a href="mailto:aaron@aaronballman.com" \
target="_blank">aaron@aaronballman.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">On Fri, Jul 24, 2015 at 3:27 PM, Nathan Wilson <<a \
href="mailto:nwilson20@gmail.com">nwilson20@gmail.com</a>> wrote:<br> ><br>
><br>
> On Fri, Jul 24, 2015 at 2:14 PM, Aaron Ballman <<a \
href="mailto:aaron@aaronballman.com">aaron@aaronballman.com</a>><br> > \
wrote:<br> >><br>
>> On Fri, Jul 24, 2015 at 2:43 PM, Nathan Wilson <<a \
href="mailto:nwilson20@gmail.com">nwilson20@gmail.com</a>><br> <span \
class="">>> wrote:<br> >> > nwilson created this revision.<br>
>> > nwilson added reviewers: rsmith, faisalv, fraggamuffin,<br>
>> > hubert.reinterpretcast.<br>
>> > nwilson added a subscriber: cfe-commits.<br>
>> ><br>
>> > Adding diagnostic for concepts declared as non template (function \
or<br> >> > variable)<br>
>> ><br>
>> > <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llv \
m.org_D11490&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREe \
q0cCxk&m=Cy8MzNPK3FdAX67YBDWB2xoWCEPICZ9_MIkvhLBsvl4&s=tBY56OYkhlr2nwDVntH13bYNysNq6HIrso27A1MbWo8&e=" \
rel="noreferrer" target="_blank">http://reviews.llvm.org/D11490</a><br> >><br>
>> ><br>
</span><div><div class="h5">>> > Files:<br>
>> > include/clang/Basic/DiagnosticSemaKinds.td<br>
>> > lib/Sema/SemaDecl.cpp<br>
>> > test/SemaCXX/cxx-concept-declaration.cpp<br>
>> ><br>
>> > Index: test/SemaCXX/cxx-concept-declaration.cpp<br>
>> > ===================================================================<br>
>> > --- test/SemaCXX/cxx-concept-declaration.cpp<br>
>> > +++ test/SemaCXX/cxx-concept-declaration.cpp<br>
>> > @@ -15,3 +15,7 @@<br>
>> > struct C {<br>
>> > template<typename T> static concept bool D3 = true; // \
expected-error<br> >> > {{concept declarations may only appear in namespace \
scope}}<br> >> > };<br>
>> > +<br>
>> > +concept bool D4() { return true; } // expected-error {{concept can \
only<br> >> > be applied to a function or variable template definition}}<br>
>> > +<br>
>> > +concept bool D5 = true; // expected-error {{concept can only be \
applied<br> >> > to a function or variable template definition}}<br>
>> > Index: lib/Sema/SemaDecl.cpp<br>
>> > ===================================================================<br>
>> > --- lib/Sema/SemaDecl.cpp<br>
>> > +++ lib/Sema/SemaDecl.cpp<br>
>> > @@ -4865,6 +4865,12 @@<br>
>> > // C++ Concepts TS [dcl.spec.concept]p1: The concept \
specifier<br> >> > shall be<br>
>> > // applied only to the definition of a function template or<br>
>> > variable<br>
>> > // template, declared in namespace scope<br>
>> > + if (!TemplateParamLists.size()) {<br>
>> > + Diag(D.getDeclSpec().getConceptSpecLoc(),<br>
>> > + diag::err_concept_decl_non_template);<br>
>> > + return nullptr;<br>
>> > + }<br>
>> > +<br>
>> > if (!DC->getRedeclContext()->isFileContext()) {<br>
>> > Diag(D.getIdentifierLoc(),<br>
>> > \
diag::err_concept_decls_may_only_appear_in_namespace_scope);<br> >> > Index: \
include/clang/Basic/DiagnosticSemaKinds.td<br> >> > \
===================================================================<br> >> > \
--- include/clang/Basic/DiagnosticSemaKinds.td<br> >> > +++ \
include/clang/Basic/DiagnosticSemaKinds.td<br> >> > @@ -1966,6 +1966,8 \
@@<br> >> > "use __attribute__((visibility(\"hidden\"))) \
attribute instead">;<br> >> ><br>
>> > // C++ Concepts TS<br>
>> > +def err_concept_decl_non_template : Error<<br>
>> > + "concept can only be applied to a function or variable \
template<br> >> > definition">;<br>
>><br>
>> Since we are using "concept" as a grammar term, I think we want \
to<br> >> quote it. Similar diagnostics suggest phrasing like:<br>
>><br>
>> "'concept' can only appear on a function template or variable \
template<br> >> definition"<br>
>><br>
>> This also reduces some ambiguity over how "function or variable \
template"<br> >> binds.<br>
>><br>
>> ~Aaron<br>
><br>
><br>
> May we apply both this suggestion and Hubert's? So it would be:<br>
><br>
> "the 'concept' specifier may only be applied to the definition of a \
function<br> > or variable template"<br>
<br>
</div></div>I don't have a strong preference, but I think "specifier may \
only be"<br> is kind of wordy without adding much value. For comparison:<br>
<br>
def err_inline_non_function : Error<<br>
"'inline' can only appear on functions">;<br>
def err_noreturn_non_function : Error<<br>
"'_Noreturn' can only appear on functions">;<br>
def err_virtual_non_function : Error<<br>
"'virtual' can only appear on non-static member \
functions">;<br> def err_explicit_non_function : Error<<br>
"'explicit' can only appear on non-static member \
functions">;<br> <br>
~Aaron<br>
<span class=""><br>
><br>
>><br>
>><br>
>> > def err_concept_decls_may_only_appear_in_namespace_scope : \
Error<<br> >> > "concept declarations may only appear in \
namespace scope">;<br> >> > def err_function_concept_not_defined : \
Error<<br> >> ><br>
>> ><br>
>> ><br>
>> > _______________________________________________<br>
>> > cfe-commits mailing list<br>
</span>>> > <a \
href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br> >> > \
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" rel="noreferrer" \
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br> \
>> ><br> ><br>
><br>
</blockquote></div><br></div>
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic