[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] D11300: Allow PenaltyBreakBeforeFirstCallParameter to not break Obj-C call before first 
From:       Daniel Jasper <djasper () google ! com>
Date:       2015-07-21 23:06:59
Message-ID: f568480e21f13fa8d3e363699280cd0b () localhost ! localdomain
[Download RAW message or body]

djasper added inline comments.

================
Comment at: lib/Format/TokenAnnotator.cpp:1701
@@ -1700,2 +1700,3 @@
       return Style.PenaltyReturnTypeOnItsOwnLine;
-    return 200;
+    unsigned penalty = 200;
+    if(Right.is(TT_StartOfName)) {
----------------
I don't understand this change. Could you elaborate?

================
Comment at: unittests/Format/FormatTest.cpp:7343-7344
@@ +7342,4 @@
+
+  // TODO: logic in ContinuationIndenter::moveStatePastFakeLParens adds more
+  // spaces than expected to second line.
+  verifyFormat("[[self foo] function:\n"
----------------
No, this is exactly as many spaces as intended. It is 4 spaces from "function".


Repository:
  rL LLVM

http://reviews.llvm.org/D11300




_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
[prev in list] [next in list] [prev in thread] [next in thread]