[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] D11027: [CONCEPTS] Creating Diagnostics for ill-formed function concept declaration
From:       Richard Smith <richard () metafoo ! co ! uk>
Date:       2015-07-18 0:04:00
Message-ID: 7d20a48e06f7d9a9c17ca027a53d8475 () localhost ! localdomain
[Download RAW message or body]

rsmith added inline comments.

================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1965-1966
@@ +1964,4 @@
+  "concept declarations may only appear in namespace scope">;
+def err_function_concept_not_defined : Error<
+  "function concept declaration must be a definition">;
+
----------------
nwilson wrote:
> rsmith wrote:
> > Does this not also apply to variable concepts? For instance
> > 
> >   template<typename T> extern concept bool b;
> Could we create a separate diagnostic for that?  i.e.:
> 
> def err_variable_concept_not_intialized : Error<
>   "variable concept declaration requires initialization">;
That seems fine to me.


http://reviews.llvm.org/D11027




_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
[prev in list] [next in list] [prev in thread] [next in thread]