[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] D11194: Instantiate function declarations in instantiated functions.
From:       Serge Pavlov <sepavloff () gmail ! com>
Date:       2015-07-16 17:36:44
Message-ID: 606e011a608f25277f30084e763ae777 () localhost ! localdomain
[Download RAW message or body]

sepavloff added inline comments.

================
Comment at: lib/Sema/SemaTemplateInstantiate.cpp:1695
@@ +1694,3 @@
+    } else if (OwningFunc->getLexicalDeclContext()->isFunctionOrMethod() &&
+               !OwningFunc->isThisDeclarationADefinition()) {
+      // This is a function declaration within a function definition, as in:
----------------
rsmith wrote:
> Is this necessary? A local function declaration can't be a definition.
As clang do not support nested functions, it is not necessary. Remove it.


http://reviews.llvm.org/D11194




_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic