[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    r242021 - Update comment
From:       Ulrich Weigand <ulrich.weigand () de ! ibm ! com>
Date:       2015-07-13 11:52:14
Message-ID: 20150713115214.CBCC62A6C02F () llvm ! org
[Download RAW message or body]

Author: uweigand
Date: Mon Jul 13 06:52:14 2015
New Revision: 242021

URL: http://llvm.org/viewvc/llvm-project?rev=242021&view=rev
Log:
Update comment

As noticed by David Majnemer, update an out-of-date comment in
CGClass.cpp after the r241916 commit.


Modified:
    cfe/trunk/lib/CodeGen/CGClass.cpp

Modified: cfe/trunk/lib/CodeGen/CGClass.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGClass.cpp?rev=242021&r1=242020&r2=242021&view=diff
 ==============================================================================
--- cfe/trunk/lib/CodeGen/CGClass.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGClass.cpp Mon Jul 13 06:52:14 2015
@@ -917,11 +917,7 @@ namespace {
           CGF.getTypes().getCGRecordLayout(FirstField->getParent());
         const CGBitFieldInfo &BFInfo = RL.getBitFieldInfo(FirstField);
         // FirstFieldOffset is not appropriate for bitfields,
-        // it won't tell us what the storage offset should be and thus might not
-        // be properly aligned.
-        //
-        // Instead calculate the storage offset using the offset of the field in
-        // the struct type.
+        // we need to use the storage offset instead.
         FirstByteOffset = CGF.getContext().toBits(BFInfo.StorageOffset);
       } else {
         FirstByteOffset = FirstFieldOffset;


_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic