[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: r241564 - Don't rely on the use of non-POD types within unions.
From:       Yaron Keren <yaron.keren () gmail ! com>
Date:       2015-07-07 17:05:57
Message-ID: CANa4zJoBC0FyiZcmYG-4H2Dtz7WiP3M2EnaBtY_=YTYB+6csxg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Thanks!

2015-07-07 18:55 GMT+03:00 Douglas Gregor <dgregor@apple.com>:

> 
> > On Jul 7, 2015, at 7:10 AM, Ed Maste <emaste@freebsd.org> wrote:
> > 
> > On 7 July 2015 at 05:45, Yaron Keren <yaron.keren@gmail.com> wrote:
> > > Hi Douglas,
> > > 
> > > One of these Objective C patches breaks Visual C++ compilation, see
> > > 
> > > 
> > > 
> http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/1803/steps/build%20stage%201/logs/stdio
> 
> > 
> > r241564 also introduced large number of warnings in the LLDB build
> > (FreeBSD Clang 3.4.1 host compiler):
> > 
> > [1968/2454] Building CXX object
> tools/...bCommands.dir/CommandObjectFrame.cpp.o
> > In file included from
> ../tools/lldb/source/Commands/CommandObjectFrame.cpp:25:
> > In file included from
> > ../tools/lldb/include/lldb/DataFormatters/DataVisualization.h:20:
> > In file included from
> > ../tools/lldb/include/lldb/DataFormatters/FormatManager.h:23:
> > In file included from
> > ../tools/lldb/include/lldb/DataFormatters/FormattersContainer.h:19:
> > ../tools/lldb/../clang/include/clang/AST/DeclObjC.h:613:5: warning:
> > anonymous types declared in an anonymous union are an extension
> > [-Wnested-anon-types]
> > struct {
> > ^
> > 1 warning generated.
> 
> 
> Addressed in r241598.
> 
> - Doug
> 
> 


[Attachment #5 (text/html)]

<div dir="rtl"><div dir="ltr">Thanks!</div></div><div class="gmail_extra"><br><div \
class="gmail_quote"><div dir="ltr">2015-07-07 18:55 GMT+03:00 Douglas Gregor <span \
dir="ltr">&lt;<a href="mailto:dgregor@apple.com" \
target="_blank">dgregor@apple.com</a>&gt;</span>:</div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><br> &gt; On Jul 7, 2015, \
at 7:10 AM, Ed Maste &lt;<a \
href="mailto:emaste@freebsd.org">emaste@freebsd.org</a>&gt; wrote:<br> &gt;<br>
&gt; On 7 July 2015 at 05:45, Yaron Keren &lt;<a \
href="mailto:yaron.keren@gmail.com">yaron.keren@gmail.com</a>&gt; wrote:<br> &gt;&gt; \
Hi Douglas,<br> &gt;&gt;<br>
&gt;&gt; One of these Objective C patches breaks Visual C++ compilation, see<br>
&gt;&gt;<br>
&gt;&gt;<br>
&gt;&gt; <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8 \
011_builders_clang-2Dx86-2Dwin2008-2Dselfhost_builds_1803_steps_build-2520stage-25201_ \
logs_stdio&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0 \
cCxk&m=7uY-C_xI_4Qzks0k0KRMNevbeeOwLHlqGvOSWzPrDiA&s=YtmlWGYNG6x4lZ3_U_OBHhwaH7Xy9mK_0Rpfh8ZMk6E&e=" \
rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/1803/steps/build%20stage%201/logs/stdio</a><br>
 &gt;<br>
&gt; r241564 also introduced large number of warnings in the LLDB build<br>
&gt; (FreeBSD Clang 3.4.1 host compiler):<br>
&gt;<br>
&gt; [1968/2454] Building CXX object \
tools/...bCommands.dir/CommandObjectFrame.cpp.o<br> &gt; In file included from \
../tools/lldb/source/Commands/CommandObjectFrame.cpp:25:<br> &gt; In file included \
from<br> &gt; ../tools/lldb/include/lldb/DataFormatters/DataVisualization.h:20:<br>
&gt; In file included from<br>
&gt; ../tools/lldb/include/lldb/DataFormatters/FormatManager.h:23:<br>
&gt; In file included from<br>
&gt; ../tools/lldb/include/lldb/DataFormatters/FormattersContainer.h:19:<br>
&gt; ../tools/lldb/../clang/include/clang/AST/DeclObjC.h:613:5: warning:<br>
&gt; anonymous types declared in an anonymous union are an extension<br>
&gt; [-Wnested-anon-types]<br>
&gt;      struct {<br>
&gt;      ^<br>
&gt; 1 warning generated.<br>
<br>
<br>
</div></div>Addressed in r241598.<br>
<br>
            - Doug<br>
<br>
</blockquote></div><br></div>



_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]