[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] Add -Wrange-loop-analysis to warn when a range-based for-loop is creating a copy.
From:       Richard Trieu <rtrieu () google ! com>
Date:       2015-02-27 22:54:29
Message-ID: 1150a6c4b3b667a9f5acf253a7143117 () localhost ! localdomain
[Download RAW message or body]

In http://reviews.llvm.org/D4169#131597, @dblaikie wrote:

> In http://reviews.llvm.org/D4169#68650, @dblaikie wrote:
> 
> > You could probably be a bit narrower than POD types - probably just
> > types with trivial copy constructors. But for now "all POD types"
> > shouldn't have any false positives, only false negatives - so perhaps
> > leave it that way with a FIXME Describing a narrower check for small
> > types (small to be defined/discovered) with trivial copy construction.
> 
> 
> Have you addressed these suggestions?
> 
> I don't recall where this was all left, exactly.


Currently, all POD types for copies are ignored.  There is a comment to only ignore \
types with trivial constructors and to figure out a proper size for small in a future \
revision.


http://reviews.llvm.org/D4169

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]