[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] Add FreeBSD ARM EABI hard-float support
From:       Saleem Abdulrasool <compnerd () compnerd ! org>
Date:       2014-01-26 18:47:55
Message-ID: CANXyDxvOQOmOrvBgR7GFqiNbU=H3R=8gz_VzguVvqtOL82qy_A () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Sun, Jan 26, 2014 at 10:13 AM, Andrew Turner <andrew@fubar.geek.nz>wrote:

> On Sun, 26 Jan 2014 08:47:37 -0800
> Saleem Abdulrasool <compnerd@compnerd.org> wrote:
> > Isn't gnueabihf equivalent to gnueabi with the difference being that
> > it uses the hardfloat ABI?  If so, why are you conditionalising the
> > exception model based on gnueabihf?
>
> The code to select the exception model was already checking if it is
> building for EABI or GNU EABI. This patch adds gnueabihf to that check.


Ah, of course, the gnueabihf is an EABI compatible environment, so it
should be using EHABI for the exception model.

LGTM.


>
> Andrew
>

-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org

[Attachment #5 (text/html)]

<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Sun, Jan 26, 2014 \
at 10:13 AM, Andrew Turner <span dir="ltr">&lt;<a href="mailto:andrew@fubar.geek.nz" \
target="_blank">andrew@fubar.geek.nz</a>&gt;</span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div class="im">On Sun, 26 Jan 2014 08:47:37 -0800<br> Saleem \
Abdulrasool &lt;<a href="mailto:compnerd@compnerd.org">compnerd@compnerd.org</a>&gt; \
wrote:<br> &gt; Isn&#39;t gnueabihf equivalent to gnueabi with the difference being \
that<br> &gt; it uses the hardfloat ABI?   If so, why are you conditionalising \
the<br> &gt; exception model based on gnueabihf?<br>
<br>
</div>The code to select the exception model was already checking if it is<br>
building for EABI or GNU EABI. This patch adds gnueabihf to that \
check.</blockquote><div><br></div><div>Ah, of course, the gnueabihf is an EABI \
compatible environment, so it should be using EHABI for the exception model.</div> \
<div><br></div><div>LGTM.</div><div>  </div><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span \
class="HOEnZb"><font color="#888888"><br> Andrew<br>
</font></span></blockquote></div><div><br></div>-- <br>Saleem Abdulrasool<br>compnerd \
(at) compnerd (dot) org </div></div>



_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]