[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: Unify unix and windows versions of FileManager::UniqueDirContainer and FileManager::UniqueFileCo
From:       Rafael_Espíndola <rafael.espindola () gmail ! com>
Date:       2013-07-31 19:27:20
Message-ID: CAG3jRe+gB_3=YOLVngueKH4o3efdRK5446k0nyJAMx3WzwxOLA () mail ! gmail ! com
[Download RAW message or body]

On 31 July 2013 14:57, Sean Silva <silvas@purdue.edu> wrote:
> -      ::Emit32(Out, (uint32_t) StatBuf->st_ino);
> -      ::Emit32(Out, (uint32_t) StatBuf->st_dev);
> -      ::Emit16(Out, (uint16_t) StatBuf->st_mode);
> -      ::Emit64(Out, (uint64_t) StatBuf->st_mtime);
> -      ::Emit64(Out, (uint64_t) StatBuf->st_size);
> -      delete StatBuf;
> +      ::Emit64(Out, Data->UniqueID.getFile());
> +      ::Emit64(Out, Data->UniqueID.getDevice());
> +      ::Emit64(Out, Data->ModTime);
> +      ::Emit64(Out, Data->Size);
> +      delete Data;
>
> This seems like it changes the PTH file format. Is there some format version
> number you need to bump somewhere? Or is this a "private" format?

I was assuming it was private. I.E., the reader must be the same as
the writer. Is that not the case?

> -- Sean Silva

Cheers,
Rafael
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
[prev in list] [next in list] [prev in thread] [next in thread]