[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] PR12463 : Warnings about nonsensical comparisons are disabled if macro expansion is invo
From:       Lubos Lunak <l.lunak () suse ! cz>
Date:       2013-07-28 10:41:32
Message-ID: 201307281241.32496.l.lunak () suse ! cz
[Download RAW message or body]

On Monday 01 of July 2013, Eli Friedman wrote:
> On Sat, Jun 29, 2013 at 11:23 PM, Lubos Lunak <l.lunak@suse.cz> wrote:
> >  Hello,
> >
> >  could somebody please review and commit the atached patch for pr12463?
> > Thank
> > you.
> >
> > +    bool InMacro = LHS.get()->getLocStart().isMacroID() ||
>
> +                   RHS.get()->getLocStart().isMacroID();
>
> Why not just check the source location of the operator itself?  It seems
> like we want to diagnose "MYMACRO1 == MYMACRO2".

 I don't know, because that's not my code. If you look at the patch, this is 
just moved out of the first if(), in order to prevent it from applying to all 
the cases. So maybe it's a good question, but it's not really part of this 
issue.

-- 
 Lubos Lunak
 l.lunak@suse.cz
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
[prev in list] [next in list] [prev in thread] [next in thread]