[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] PR14795 : -frewrite-includes sometimes results in incorrect line number
From:       Eli Friedman <eli.friedman () gmail ! com>
Date:       2013-07-16 0:29:43
Message-ID: CAJdarcF_R1NRrKkGVb_6WWwrV7xuiS+V0=iyZ0U2quTot5B3jA () mail ! gmail ! com
[Download RAW message or body]

On Sun, Jul 14, 2013 at 2:16 PM, Lubos Lunak <l.lunak@suse.cz> wrote:
> On Monday 01 of July 2013, Eli Friedman wrote:
>> On Sat, Jun 29, 2013 at 11:35 PM, Lubos Lunak <l.lunak@suse.cz> wrote:
>> >  Hello,
>> >
>> >  could somebody please review and commit the atached patch for pr14795?
>> > Thank
>> > you.
>>
>> --- a/lib/Lex/Lexer.cpp
>> +++ b/lib/Lex/Lexer.cpp
>> @@ -2372,8 +2372,9 @@ bool Lexer::LexEndOfFile(Token &Result, const char
>> *CurPtr) {
>>      FormTokenWithChars(Result, CurPtr, tok::eod);
>>
>>      // Restore comment saving mode, in case it was disabled for directive.
>> -    resetExtendedTokenMode();
>> -    return true;  // Have a token.
>> +    if (PP)
>> +      resetExtendedTokenMode();
>> +    return true; // Have a token.
>>    }
>>
>>    // If we are in raw mode, return this event as an EOF token.  Let the
>> caller
>>
>> How is this related?
>
>  I had a crash there without this when I wrote the patch. I don't remember the
> circumstances though and the random testcase I tried doesn't trigger it.

Okay.

Please commit without this change.

-Eli
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
[prev in list] [next in list] [prev in thread] [next in thread]