[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [cfe-commits] [libcxx] r157764 - in /libcxx/trunk: include/__config src/iostream.cpp
From:       Chandler Carruth <chandlerc () google ! com>
Date:       2012-05-31 19:58:43
Message-ID: CAGCO0KiTr8AGie3_6BqkiaD8iO2jtymM3D6qX8nUVJsbGBUQfw () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Thu, May 31, 2012 at 12:31 PM, Howard Hinnant <hhinnant@apple.com> wrote:

> Author: hhinnant
> Date: Thu May 31 14:31:14 2012
> New Revision: 157764
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=157764&view=rev
> Log:
> Protect use of alignas against older versions of clang
> 
> Modified:
> libcxx/trunk/include/__config
> libcxx/trunk/src/iostream.cpp
> 
> Modified: libcxx/trunk/include/__config
> URL:
> http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/__config?rev=157764&r1=157763&r2=157764&view=diff
>  
> ==============================================================================
> --- libcxx/trunk/include/__config (original)
> +++ libcxx/trunk/include/__config Thu May 31 14:31:14 2012
> @@ -145,8 +145,10 @@
> #if defined(__clang__)
> 
> #if __has_feature(cxx_alignas)
> +#  define _ALIGNAS_TYPE(x) alignas(x)
> #  define _ALIGNAS(x) alignas(x)
> #else
> +#  define _ALIGNAS_TYPE(x) __attribute__((__aligned__))
> 

Should this be __aligned__(x) as it is here:


> #  define _ALIGNAS(x) __attribute__((__aligned__(x)))
> 

Or are you intentionally shooting for the 'maximally aligned' thing? If the
latter, maybe comment that this is intentional and not a typo?


[Attachment #5 (text/html)]

<div class="gmail_quote">On Thu, May 31, 2012 at 12:31 PM, Howard Hinnant <span \
dir="ltr">&lt;<a href="mailto:hhinnant@apple.com" \
target="_blank">hhinnant@apple.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
                solid;padding-left:1ex">
Author: hhinnant<br>
Date: Thu May 31 14:31:14 2012<br>
New Revision: 157764<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=157764&amp;view=rev" \
target="_blank">http://llvm.org/viewvc/llvm-project?rev=157764&amp;view=rev</a><br> \
Log:<br> Protect use of alignas against older versions of clang<br>
<br>
Modified:<br>
      libcxx/trunk/include/__config<br>
      libcxx/trunk/src/iostream.cpp<br>
<br>
Modified: libcxx/trunk/include/__config<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/__config?rev=157764&amp;r1=157763&amp;r2=157764&amp;view=diff" \
target="_blank">http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/__config?rev=157764&amp;r1=157763&amp;r2=157764&amp;view=diff</a><br>


==============================================================================<br>
--- libcxx/trunk/include/__config (original)<br>
+++ libcxx/trunk/include/__config Thu May 31 14:31:14 2012<br>
@@ -145,8 +145,10 @@<br>
  #if defined(__clang__)<br>
<br>
  #if __has_feature(cxx_alignas)<br>
+#   define _ALIGNAS_TYPE(x) alignas(x)<br>
  #   define _ALIGNAS(x) alignas(x)<br>
  #else<br>
+#   define _ALIGNAS_TYPE(x) \
__attribute__((__aligned__))<br></blockquote><div><br></div><div>Should this be \
__aligned__(x) as it is here:</div><div>  </div><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

  #   define _ALIGNAS(x) \
__attribute__((__aligned__(x)))<br></blockquote><div><br></div><div>Or are you \
intentionally shooting for the &#39;maximally aligned&#39; thing? If the latter, \
maybe comment that this is intentional and not a typo?</div> </div>



_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]