[prev in list] [next in list] [prev in thread] [next in thread]
List: cfe-commits
Subject: Re: [cfe-commits] [PATCH] Fix object lifetime issue in clang/Tooling
From: Alexander Kornienko <alexfh () google ! com>
Date: 2012-05-31 19:26:58
Message-ID: CAOweq9LCqm+HXEPvREJmjqVn+5i-c2JB9ObufbnAkRkJXQxkdw () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Thanks! Committed as r157759.
On Thu, May 31, 2012 at 7:57 PM, Manuel Klimek <klimek@google.com> wrote:
> s/TempToolAction/ScopedToolAction/.
>
> Apart from that lgtm.
>
>
> On Thu, May 31, 2012 at 7:48 PM, Alexander Kornienko <alexfh@google.com>wrote:
>
>> Hi,
>>
>> I've changed this patch to be more clear.
>> Please, take a look. Thanks!
>>
>>
>> On Thu, May 31, 2012 at 2:29 PM, Alexander Kornienko <alexfh@google.com>wrote:
>>
>>> Hi,
>>>
>>> This patch fixes an object lifetime issue in clang/Tooling.
>>>
>>> Could you, please, review it? Thanks!
>>>
>>> --
>>> Best regards,
>>> Alexander Kornienko
>>>
>>
>> --
>> Best regards,
>> Alexander Kornienko
>>
>
>
--
Alexander Kornienko | Software Engineer | alexfh@google.com | +49 151 221
77 957
Google Germany GmbH | Dienerstr. 12 | 80331 München
AG Hamburg, HRB 86891 | Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Katherine Stephens
Tax ID:- 48/725/00206
VAT ID:- DE813741370
[Attachment #5 (text/html)]
Thanks! Committed as r157759.<br><br><div class="gmail_quote">On Thu, May 31, 2012 at \
7:57 PM, Manuel Klimek <span dir="ltr"><<a href="mailto:klimek@google.com" \
target="_blank">klimek@google.com</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> s/TempToolAction/ScopedToolAction/.<div><br></div><div>Apart \
from that lgtm.<div><br><br><div class="gmail_quote">On Thu, May 31, 2012 at 7:48 PM, \
Alexander Kornienko <span dir="ltr"><<a href="mailto:alexfh@google.com" \
target="_blank">alexfh@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi,<div><br></div><div>I've changed this patch to be more \
clear.</div><div>Please, take a look. Thanks!<div><div> <br><br><div \
class="gmail_quote">On Thu, May 31, 2012 at 2:29 PM, Alexander Kornienko <span \
dir="ltr"><<a href="mailto:alexfh@google.com" \
target="_blank">alexfh@google.com</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi,<div><br></div><div>This patch fixes an object lifetime \
issue in clang/Tooling.</div><div><br></div><div>Could you, please, review it? \
Thanks!</div>
<span><font color="#888888"><div><br clear="all"><div>-- </div><div>Best \
regards,</div><div>Alexander Kornienko</div>
</div>
</font></span></blockquote></div><br>--
<div>Best regards,</div><div>Alexander Kornienko</div></div></div></div>
</blockquote></div><br></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div><font \
color="#666666"><span \
style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left \
-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;b \
order-left-style:solid;border-top-color:rgb(213,15,37);border-right-color:rgb(213,15,3 \
7);border-bottom-color:rgb(213,15,37);border-left-color:rgb(213,15,37);padding-top:2px;margin-top:2px">Alexander \
Kornienko |</span><span \
style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left \
-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;b \
order-left-style:solid;border-top-color:rgb(51,105,232);border-right-color:rgb(51,105, \
232);border-bottom-color:rgb(51,105,232);border-left-color:rgb(51,105,232);padding-top:2px;margin-top:2px"> \
Software Engineer |</span></font><span \
style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left \
-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;b \
order-left-style:solid;border-top-color:rgb(0,153,57);border-right-color:rgb(0,153,57) \
;border-bottom-color:rgb(0,153,57);border-left-color:rgb(0,153,57);padding-top:2px;margin-top:2px"><font \
color="#666666"> </font><a href="mailto:alexfh@google.com" \
style="color:rgb(17,85,204)" target="_blank">alexfh@google.com</a> |</span><span \
style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left \
-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;b \
order-left-style:solid;border-top-color:rgb(238,178,17);border-right-color:rgb(238,178 \
,17);border-bottom-color:rgb(238,178,17);border-left-color:rgb(238,178,17);padding-top:2px;margin-top:2px"> \
<a value="+35315435283" style="color:rgb(17,85,204)">+49 151 221 77 \
957</a></span></div>
</div><div><font color="#666666"><span \
style="font-family:Arial,Verdana,sans-serif">Google Germany GmbH | </span><span \
style="font-family:Arial,Verdana,sans-serif">Dienerstr. 12 | </span><span \
style="font-family:Arial,Verdana,sans-serif">80331 München</span></font></div>
<div><div style="font-size:13px;font-family:Arial,Verdana,sans-serif"><font \
color="#666666"><font><br>AG Hamburg, HRB 86891 | Sitz der Gesellschaft: </font><font \
face="arial, sans-serif">Hamburg</font><font><br> Geschäftsführer: Graham Law, \
Katherine Stephens<span style="border-collapse:separate"><span \
style="font-family:inherit"><br></span></span></font></font></div><div \
style="font-size:13px;font-family:Arial,Verdana,sans-serif">
<font color="#666666"><br></font></div><div \
style="font-size:13px;font-family:Arial,Verdana,sans-serif"><font><span \
style="border-collapse:collapse"><font face="arial, sans-serif" color="#666666">Tax \
ID:- 48/725/00206 </font></span></font></div>
<div style="font-size:13px;font-family:Arial,Verdana,sans-serif"><font><span \
style="border-collapse:collapse"><font face="arial, sans-serif" color="#666666">VAT \
ID:- DE813741370</font></span></font></div> </div><br>
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic