[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [cfe-commits] Fix handling of ARM homogenous aggregates
From:       Anton Korobeynikov <anton () korobeynikov ! info>
Date:       2012-03-30 19:06:40
Message-ID: CA+Ov9+kT7jASTkOiL1oR6bxPkSu1N7j0uXmaMXLh6StOBD=X3Q () mail ! gmail ! com
[Download RAW message or body]

> It seems that I misunderstood the meaning of the "isAggregate" method.  I didn't realize that having private fields would cause that to return false.  As long as you exclude classes with vtables, that should be fine.
It's testing for C++ aggregate, so it should not contain user-defined
ctors (no problem for h. aggregates), no private or protected
non-static members (no problem for h. aggregates), no base classes (no
problems for h. aggregates) and not virtual functions.

So, the check isAggregate() is not correct... I will add testcase for
vtables as well.

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University

_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

[prev in list] [next in list] [prev in thread] [next in thread]