[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [cfe-commits] [PATCH] Add Win64 var arg support
From:       Chris Lattner <clattner () apple ! com>
Date:       2010-08-31 16:46:13
Message-ID: E6FC2380-C9D0-4687-A957-54AD7BC93631 () apple ! com
[Download RAW message or body]

Applied in r112603, thanks!  Can I trick you into writing some sort of win64 test for \
the clang testsuite so we know it has basic functionality?

-Chris

On Aug 31, 2010, at 3:25 AM, Cameron Esfahani wrote:

> Here's even a betterer patch which fixes an alignment issue:
> 
> <clang_va.patch>
> 
> 
> Based on revision 112597.
> 
> On Aug 27, 2010, at 3:15 PM, Cameron Esfahani wrote:
> 
> > Here's better version which funnels the MingW64 and Cygwin X86_64 targets into \
> > the same ABIInfo as the Windows64 version. 
> > Also, I removed a case for MingW64 in the 32-bit case.  It should have never been \
> > there... 
> > <clang_va.patch>
> > On Aug 27, 2010, at 2:57 PM, Anton Korobeynikov wrote:
> > 
> > > Hello Cameron,
> > > 
> > > > Win64 uses a different format for var args than the other x86_64 targets.  \
> > > > It's very similar to the Win32, so I started from there.
> > > I don't this this is a proper solution.... E.g. mingw on win64 also
> > > uses this ABI, so the code should be generalized somehow.
> > > 
> > > -- 
> > > With best regards, Anton Korobeynikov
> > > Faculty of Mathematics and Mechanics, Saint Petersburg State University
> > 
> > Cameron Esfahani
> > dirty@apple.com
> > 
> > "There are times in the life of a nation when the only place a decent man can \
> > find himself is in prison." 
> > 
> > 
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits@cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 
> Cameron Esfahani
> dirty@apple.com
> 
> "You only live once, and the way I live, once is enough"
> 
> Frank Sinatra
> 
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits@cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits


_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]