[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [cfe-commits] r72673 - in /cfe/trunk: lib/Sema/SemaExprCXX.cpp
From:       Anders Carlsson <andersca () mac ! com>
Date:       2009-05-31 21:53:10
Message-ID: 422DEAC9-FD62-4459-86D6-CAF71C17A324 () mac ! com
[Download RAW message or body]


On May 31, 2009, at 2:52 PM, Sebastian Redl wrote:

> Anders Carlsson wrote:
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- cfe/trunk/lib/Sema/SemaExprCXX.cpp (original)
>> +++ cfe/trunk/lib/Sema/SemaExprCXX.cpp Sun May 31 15:26:12 2009
>> @@ -508,6 +508,11 @@
>>       return true;
>>   }
>>
>> +  // FindAllocationOverload can change the passed in arguments, so  
>> we need to
>> +  // copy them back.
>> +  if (NumPlaceArgs > 0)
>> +    std::copy(&AllocArgs[1], AllocArgs.end(), PlaceArgs);
>> +
>>
> Why, so it can! I never thought about this.
> Hmm, now I wonder how many times I've made this mistake ...

:) Luckily we have good asserts that catch this in irgen.

Anders

_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

[prev in list] [next in list] [prev in thread] [next in thread]