[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ceph-devel
Subject:    Re: [PATCH v2 2/2] ceph: add IO size metrics support
From:       Xiubo Li <xiubli () redhat ! com>
Date:       2021-04-28 1:24:59
Message-ID: 7a23da97-6e2c-3e8b-b5a7-436c913c0f30 () redhat ! com
[Download RAW message or body]

On 2021/4/28 2:41, Jeff Layton wrote:
> On Thu, 2021-03-25 at 11:28 +0800, xiubli@redhat.com wrote:
...
>> +static inline void __update_size(struct ceph_client_metric *m,
>> +				 metric_type type, unsigned int size)
>> +{
>> +	switch (type) {
>> +	case CEPH_METRIC_READ:
>> +		++m->total_reads;
>> +		m->read_size_sum += size;
>> +		METRIC_UPDATE_MIN_MAX(m->read_size_min,
>> +				      m->read_size_max,
>> +				      size);
>> +		return;
>> +	case CEPH_METRIC_WRITE:
>> +		++m->total_writes;
>> +		m->write_size_sum += size;
>> +		METRIC_UPDATE_MIN_MAX(m->write_size_min,
>> +				      m->write_size_max,
>> +				      size);
>> +		return;
>> +	case CEPH_METRIC_METADATA:
>> +	default:
>> +		return;
>> +	}
>> +}
>> +
> Ditto here re: patch 1. This switch adds nothing and just adds in some
> extra branching. I'd just open code these into their (only) callers.

Sure.



[prev in list] [next in list] [prev in thread] [next in thread]