[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ceph-devel
Subject:    [GSoC] wrong patch "msg: change entity_addr_t encode/decode"
From:       Junwang Zhao <zhjwpku () gmail ! com>
Date:       2016-05-31 13:04:45
Message-ID: CAEG8a3JF2t1hkHY2MQK5DVwbOy3VGZUNuB-uF5mOzBSO8xhQeg () mail ! gmail ! com
[Download RAW message or body]

Hi Sage & Haomai,

I try to run './vstart.sh -d -x -n' to test the patches today, I got
some error like 'wrong node', after some work, I found the
error was introduced by this patch[0]. I change the code to
use the legacy decode and encode, but got stuck somewhere.

--- a/src/msg/msg_types.h
+++ b/src/msg/msg_types.h
@@ -371,7 +371,7 @@ struct entity_addr_t {
   // broader study

   void encode(bufferlist& bl, uint64_t features) const {
-    if ((features & CEPH_FEATURE_MSG_ADDR2) == 0) {
+    if ((features & CEPH_FEATURE_MSG_ADDR2) != 0) {
       ::encode((__u32)0, bl);
       ::encode(nonce, bl);
       sockaddr_storage ss = get_sockaddr_storage();


Can you please see the patch again and give some comments?

[0]https://github.com/zhjwpku/ceph/commit/8934f038fdf28156038770e601e4a27f7a684390

Thanks,
Zhao
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]