[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ceph-devel
Subject:    Re: [ceph-users] fiemap bug on giant
From:       Haomai Wang <haomaiwang () gmail ! com>
Date:       2014-11-25 3:59:29
Message-ID: CACJqLybW-VUU7iYRHdbLnD3yr+dVBqgW2kAAOA+n-LV8jwVqiw () mail ! gmail ! com
[Download RAW message or body]

Agree with you.

It seemed I made a mistake that only truncate expected size for clone
op but not truncate size for clone_range op.

We need to truncate dst file to expected length if ending with zero
filled section.

On Tue, Nov 25, 2014 at 11:30 AM, Samuel Just <sam.just@inktank.com> wrote:
> I think the bug is actually with FileStore::_do_sparse_copy_range,
> which isn't truncating out properly to create 0 filled sections.
> -Sam
> 
> On Mon, Nov 24, 2014 at 6:17 PM, Haomai Wang <haomaiwang@gmail.com> wrote:
> > Oh, sorry. This series seemed that already backported...
> > 
> > On Tue, Nov 25, 2014 at 10:14 AM, Haomai Wang <haomaiwang@gmail.com> wrote:
> > > Backport this series(https://github.com/yuandong1222/ceph/commit/3f8fb85b341726ae7bb44b4c699707333cd63ccd)
> > >  and test again ? Or....
> > > 
> > > Actually, my up to ten ceph clusters open this option for nearly one year.....
> > > 
> > > On Tue, Nov 25, 2014 at 10:05 AM, Sage Weil <sweil@redhat.com> wrote:
> > > > [dropping ceph-users]
> > > > 
> > > > On Tue, 25 Nov 2014, Haomai Wang wrote:
> > > > > It's surprised that the test machine run on a very new kernel but
> > > > > occur this problem:
> > > > > 
> > > > > plana 47 is 12.04.5 with kernel 3.18.0-rc6-ceph-00024-geb0e5fd
> > > > > 
> > > > > plana 50 is 12.04.4 with kernel 3.17.0-rc6-ceph-00002-ge8acad6
> > > > > 
> > > > > Which local filesystem is ran on?
> > > > 
> > > > This run was XFS.  It looks like it returned a mapping for fewer bytes
> > > > than it was asked for... 54548 turned into 53904.  That's a bit
> > > > disconcerting!  Maybe teh issue is that the start offset wasn't aligned?
> > > > 
> > > > sage
> > > > 
> > > > 
> > > > 
> > > > > 
> > > > > On Tue, Nov 25, 2014 at 5:03 AM, Samuel Just <sam.just@inktank.com> wrote:
> > > > > > Bug #10166 (http://tracker.ceph.com/issues/10166) can cause recovery
> > > > > > to result in incorrect object sizes on giant if the setting 'filestore
> > > > > > fiemap' is set to true.  This setting is disabled by default.  This
> > > > > > should be fixed in a future point release, though filestore fiemap
> > > > > > will probably continue to default to false.
> > > > > > -Sam
> > > > > > _______________________________________________
> > > > > > ceph-users mailing list
> > > > > > ceph-users@lists.ceph.com
> > > > > > http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com
> > > > > 
> > > > > 
> > > > > 
> > > > > --
> > > > > Best Regards,
> > > > > 
> > > > > Wheat
> > > > > _______________________________________________
> > > > > ceph-users mailing list
> > > > > ceph-users@lists.ceph.com
> > > > > http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com
> > > > > 
> > > > > 
> > > 
> > > 
> > > 
> > > --
> > > Best Regards,
> > > 
> > > Wheat
> > 
> > 
> > 
> > --
> > Best Regards,
> > 
> > Wheat



-- 
Best Regards,

Wheat
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[prev in list] [next in list] [prev in thread] [next in thread]