[prev in list] [next in list] [prev in thread] [next in thread]
List: cassandra-dev
Subject: Re: Some tests are never executed in CI due to their name
From: Andrés_de_la_Peña <adelapena () apache ! org>
Date: 2022-11-15 11:24:28
Message-ID: CANSRBLBTqR22oVfSs2KW-pR4uEZqEfuWzEhfhxi9=8ga+cwo9g () mail ! gmail ! com
[Download RAW message or body]
+1 to waiver
On Tue, 15 Nov 2022 at 05:54, Berenguer Blasi <berenguerblasi@gmail.com>
wrote:
> +1 to waiver
> On 15/11/22 2:07, Josh McKenzie wrote:
>
> +1 to waiver.
>
> We still don't have some kind of @flaky annotation that sequesters tests
> do we? :)
>
> On Mon, Nov 14, 2022, at 5:58 PM, Ekaterina Dimitrova wrote:
>
> +1
>
> On Mon, 14 Nov 2022 at 17:55, Brandon Williams <driftx@gmail.com> wrote:
>
> +1 to waiving these.
>
> On Mon, Nov 14, 2022, 4:49 PM Miklosovic, Stefan <
> Stefan.Miklosovic@netapp.com> wrote:
>
> Tickets for the flaky tests are here
>
> https://issues.apache.org/jira/browse/CASSANDRA-18047
> https://issues.apache.org/jira/browse/CASSANDRA-18048
>
> ________________________________________
> From: Mick Semb Wever <mck@apache.org>
> Sent: Monday, November 14, 2022 23:28
> To: dev@cassandra.apache.org
> Subject: Re: Some tests are never executed in CI due to their name
>
> NetApp Security WARNING: This is an external email. Do not click links or
> open attachments unless you recognize the sender and know the content is
> safe.
>
>
>
>
> in CASSANDRA-18029, two flaky tests were committed by mistake due to my
> misunderstanding. We agreed on this thread that we should not commit flaky
> tests right before rc. So now the rc is technically blocked by them. To
> unblock it, what is needed is to have a waiver on them. If there is not a
> waiver, I need to go back to that test and remove the two test methods
> which are flaky. (In practice they will be probably just @Ignore-ed with
> comment about flakiness so we can fix them later).
>
> Flaky tests are
>
>
> org.apache.cassandra.distributed.test.PaxosRepair2Test.paxosRepairHistoryIsntUpdatedInForcedRepair
>
> org.apache.cassandra.distributed.test.PaxosRepair2Test.legacyPurgeRepairLoop
>
>
> +1 to a waiver on these two 4.1 flaky regressions to the RC and GA
> releases.
>
> Thanks for bringing it back to dev@ Stefan. Waivers should be done on dev@
> (build/release managers can't be keeping up with every ticket), and dev
> threads and tickets should be kept (reasonably) in-sync, for the sake of
> inclusiveness.
>
> I believe there will be follow up tickets to address these flakies in
> 4.1.x ?
>
>
>
[Attachment #3 (text/html)]
<div dir="ltr">+1 to waiver<br></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Tue, 15 Nov 2022 at 05:54, Berenguer Blasi <<a \
href="mailto:berenguerblasi@gmail.com">berenguerblasi@gmail.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<p>+1 to waiver<br>
</p>
<div>On 15/11/22 2:07, Josh McKenzie wrote:<br>
</div>
<blockquote type="cite">
<div>+1 to waiver.<br>
</div>
<div><br>
</div>
<div>We still don't have some kind of @flaky annotation that
sequesters tests do we? :)</div>
<div><br>
</div>
<div>On Mon, Nov 14, 2022, at 5:58 PM, Ekaterina Dimitrova wrote:<br>
</div>
<blockquote type="cite" id="m_3177093747669084430qt">
<div dir="auto">+1<br>
</div>
<div>
<div><br>
</div>
<div>
<div dir="ltr">On Mon, 14 Nov 2022 at
17:55, Brandon Williams <<a href="mailto:driftx@gmail.com" \
target="_blank">driftx@gmail.com</a>> wrote:<br>
</div>
<blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"> <div dir="auto">+1 to waiving these.<br>
</div>
<div><br>
</div>
<div>
<div dir="ltr">On Mon, Nov 14,
2022, 4:49 PM Miklosovic, Stefan <<a \
href="mailto:Stefan.Miklosovic@netapp.com" \
target="_blank">Stefan.Miklosovic@netapp.com</a>> wrote:<br>
</div>
<blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"> <div>Tickets for the flaky tests are here<br>
</div>
<div> <br>
</div>
<div> <a \
href="https://issues.apache.org/jira/browse/CASSANDRA-18047" rel="noreferrer \
noreferrer" target="_blank">https://issues.apache.org/jira/browse/CASSANDRA-18047</a><br>
</div>
<div> <a \
href="https://issues.apache.org/jira/browse/CASSANDRA-18048" rel="noreferrer \
noreferrer" target="_blank">https://issues.apache.org/jira/browse/CASSANDRA-18048</a><br>
</div>
<div> <br>
</div>
<div> ________________________________________<br>
</div>
<div> From: Mick Semb Wever <<a href="mailto:mck@apache.org" \
rel="noreferrer" target="_blank">mck@apache.org</a>><br> </div>
<div> Sent: Monday, November 14, 2022 23:28<br>
</div>
<div> To: <a href="mailto:dev@cassandra.apache.org" \
rel="noreferrer" target="_blank">dev@cassandra.apache.org</a><br> </div>
<div> Subject: Re: Some tests are never executed in CI
due to their name<br>
</div>
<div> <br>
</div>
<div> NetApp Security WARNING: This is an external
email. Do not click links or open attachments unless
you recognize the sender and know the content is
safe.<br>
</div>
<div> <br>
</div>
<div> <br>
</div>
<div> <br>
</div>
<div> <br>
</div>
<div> in CASSANDRA-18029, two flaky tests were
committed by mistake due to my misunderstanding. We
agreed on this thread that we should not commit
flaky tests right before rc. So now the rc is
technically blocked by them. To unblock it, what is
needed is to have a waiver on them. If there is not
a waiver, I need to go back to that test and remove
the two test methods which are flaky. (In practice
they will be probably just @Ignore-ed with comment
about flakiness so we can fix them later).<br>
</div>
<div> <br>
</div>
<div> Flaky tests are<br>
</div>
<div> <br>
</div>
<div>
org.apache.cassandra.distributed.test.PaxosRepair2Test.paxosRepairHistoryIsntUpdatedInForcedRepair<br>
</div>
<div>
org.apache.cassandra.distributed.test.PaxosRepair2Test.legacyPurgeRepairLoop<br>
</div>
<div> <br>
</div>
<div> <br>
</div>
<div> +1 to a waiver on these two 4.1 flaky
regressions to the RC and GA releases.<br>
</div>
<div> <br>
</div>
<div> Thanks for bringing it back to dev@ Stefan.
Waivers should be done on dev@ (build/release
managers can't be keeping up with every ticket), and
dev threads and tickets should be kept (reasonably)
in-sync, for the sake of inclusiveness.<br>
</div>
<div> <br>
</div>
<div> I believe there will be follow up tickets to
address these flakies in 4.1.x ?<br>
</div>
</blockquote>
</div>
</blockquote>
</div>
</div>
</blockquote>
<div><br>
</div>
</blockquote>
</div>
</blockquote></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic