[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cassandra-dev
Subject:    Re: Warn about SASI usage and allow to disable them
From:       Sankalp Kohli <kohlisankalp () gmail ! com>
Date:       2019-01-26 18:08:17
Message-ID: 56CAAEF3-EE15-4770-A942-0EED148B2637 () gmail ! com
[Download RAW message or body]

Can we have a page or a JIRA label which users can see to know why it is experimental. Putting a warning without telling why is not good. But since warning is better than nothing, I am -0 on warn

> On Jan 26, 2019, at 9:37 AM, Andrés de la Peña <a.penya.garcia@gmail.com> wrote:
> 
> I agree with Paulo's proposal. I think it will give us a very desirable
> homogeneity in how we deal with experimental features.
> 
> I'm +1 to warning, config property, and experimental features (SASI and MV)
> disabled by default in trunk.
> 
> These are the explicit votes for now, if I'm counting right:
> 
> - CQL native protocol warning on create SASI index: three +1s, one +0 and
> two -0s
> - Config property to disable new SASI creation: ten +1s
> - New SASI creation disabled by default in trunk: nine +1s and one -0
> - New MV creation disabled by default in trunk: three +1s
> 
> If there are no objections, I'll update the patch by the end of next week.
> 
>> On Mon, 21 Jan 2019 at 19:26, Paulo Motta <pauloricardomg@gmail.com> wrote:
>> 
>> +1 to enable_sasi_indexes flag
>> +1 to disabling experimental features by default on 4.0 (SASI and MVs,
>> transient replication already disabled)
>> 
>> Regarding the warning on creation of SASI indexes, I think that's a
>> user-level warning complimentary to the flag, which is targeted to admins,
>> so +1. If people are bothered by this, we could add another flag to disable
>> warnings on experimental features, which would be applied to both this and
>> MV creation warning (and any other future experimental feature).
>> 
>> I think the warning should be "SASI indexes are experimental and are not
>> recommended for production use.", similar to the MV warning added on
>> CASSANDRA-13959.
>> 
>> We should open a doc ticket to list limitations of experimental features
>> (MVs, SASI, transient replication), but this should probably be out of the
>> scope of CASSANDRA-14866. Once we have this doc, we can maybe amend the
>> warning to include a link to the doc.
>> 
>> Now that the number of experimental feature flags is growing we should
>> perhaps unify all flags in a "experimental features" section on
>> cassandra.yaml to allow easily locating them - and a pointer to the
>> limitations doc once we have it.
>> 
>> Em qua, 16 de jan de 2019 Ã s 20:18, sankalp kohli <kohlisankalp@gmail.com>
>> escreveu:
>> 
>>> If we want to put a warning, we should list in a doc all the open issues
>> it
>>> has along with explanation of how it can impact. We have a few in the
>> first
>>> email of this thread but we should put it in a doc for people to know
>> what
>>> are the issues and if they want to take that risk.
>>> 
>>> 
>>> 
>>> On Wed, Jan 16, 2019 at 3:14 PM Brandon Williams <driftx@gmail.com>
>> wrote:
>>> 
>>>> Which, if I'm not mistaken, is the goal here?
>>>> 
>>>>> On Wed, Jan 16, 2019 at 5:12 PM Jeff Jirsa <jjirsa@gmail.com> wrote:
>>>>> 
>>>>> The cost is in how many users you scare away
>>>>> 
>>>>> --
>>>>> Jeff Jirsa
>>>>> 
>>>>> 
>>>>>> On Jan 16, 2019, at 2:34 PM, Brandon Williams <driftx@gmail.com>
>>>> wrote:
>>>>>> 
>>>>>> Also it costs us nothing to add it.
>>>>>> 
>>>>>>> On Wed, Jan 16, 2019 at 4:29 PM Jonathan Haddad <
>> jon@jonhaddad.com>
>>>>> wrote:
>>>>>>> 
>>>>>>> I'm +1 on the warning for two reasons.
>>>>>>> 
>>>>>>>> A cqlsh warning only applies to those that create the sasi via
>>> cqlsh.
>>>>>>> 
>>>>>>> 1. When people are creating their schemas in development, this is
>>>>> usually
>>>>>>> the first step.  You use the REPL to figure out what you need,
>> then
>>>> you
>>>>>>> copy your schema somewhere else.  The warning here should prevent
>> a
>>>> lot
>>>>> of
>>>>>>> folks from making a serious mistake.
>>>>>>> 
>>>>>>> 2. It's consistent with how we warn when people try to use
>>>> materialized
>>>>>>> views.
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>>> On Wed, Jan 16, 2019 at 2:15 PM Mick Semb Wever <mck@apache.org>
>>>>> wrote:
>>>>>>>> 
>>>>>>>> Regarding the warning, we might add it at least in 3.11, since
>> for
>>>> that
>>>>>>>> version the property to enable SASI is going to be present but
>> not
>>>>>>> disabled
>>>>>>>> by default. WDYT?
>>>>>>>> 
>>>>>>>> 
>>>>>>>> I'm  -0 on this.
>>>>>>>> 
>>>>>>>> A single line warning in the logs on the sasi creation won't be
>>>> noticed
>>>>>>> by
>>>>>>>> many users.
>>>>>>>> A cqlsh warning only applies to those that create the sasi via
>>> cqlsh.
>>>>>>>> And we're not talking about patching client drivers to generate a
>>>>> warning
>>>>>>>> there.
>>>>>>>> 
>>>>>>>> So I'd be happy with a yaml comment on the config flag explaining
>>>> that
>>>>>>>> it's a beta feature and that users should check open tickets and
>>>>>>> understand
>>>>>>>> current limitations on sasi before using them.
>>>>>>>> 
>>>>>>>> regards,
>>>>>>>> Mick
>>>>>>>> 
>>>>>>>> 
>>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@cassandra.apache.org
>>>>>>>> 
>>>>>>>> 
>>>>>>> 
>>>>>>> --
>>>>>>> Jon Haddad
>>>>>>> http://www.rustyrazorblade.com
>>>>>>> twitter: rustyrazorblade
>>>>>>> 
>>>>> 
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
>>>>> For additional commands, e-mail: dev-help@cassandra.apache.org
>>>>> 
>>>>> 
>>>> 
>>> 
>> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org

[prev in list] [next in list] [prev in thread] [next in thread]