[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cassandra-dev
Subject:    Re: Removing 2-phase compaction question
From:       Jason Brown <jasedbrown () gmail ! com>
Date:       2012-11-30 13:38:57
Message-ID: CAHjqPu+gP7aTxQ8wCLB31tbnjavZSeP6R=tORofNPA8V4mXvFw () mail ! gmail ! com
[Download RAW message or body]


Sylvain,

Thanks for the feedback! You're probably right about the RIE, but as this
is my first 'really deep' ticket into the bowels of c*, I'm learning the
role/purpose of everything as I'm going. As for the WIP branch, I may take
the community up on that :).

Thanks,

-Jason


On Fri, Nov 30, 2012 at 2:33 AM, Sylvain Lebresne <sylvain@datastax.com>wrote:

> > I'm finding myself modifying row serialization stuff in
> > ColumnFamilySerializer, RowIndexEntry, SSTableReader/Writer,
> > SimpleSliceReader, and others.
>
> That mostly sound about right. As said in the ticket, if we stop writing
> the
> size at the beginning of the rows, we need to have marker of the end of row
> to
> know when to stop reading. So this will change the file format somewhat and
> should have an impact on quite a bit of files. The only one I'm not sure I
> see
> why you need modification is RowIndexEntry (maybe there is a good reason,
> just
> saying that a priori I'm not seeing which one).
>
> > and that I haven't gone off the deep end
>
> Feel free to put a wip branch somewhere if you want some feedback on the
> approach, even if said branch is not even compiling.
>
> --
> Sylvain
>


[prev in list] [next in list] [prev in thread] [next in thread]