[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cassandra-commits
Subject:    [1/2] Allow populate_io_cache_on_flush to be set per-CF. Patch by Alexey Zotov, reviewed by brandwon
From:       brandonwilliams () apache ! org
Date:       2013-01-31 23:37:32
Message-ID: 20130131233732.07BBC82882A () tyr ! zones ! apache ! org
[Download RAW message or body]

http://git-wip-us.apache.org/repos/asf/cassandra/blob/22f515b3/src/java/org/apache/cassandra/io/sstable/SSTableWriter.java
                
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/io/sstable/SSTableWriter.java \
b/src/java/org/apache/cassandra/io/sstable/SSTableWriter.java index 2166808..80316e8 \
                100644
--- a/src/java/org/apache/cassandra/io/sstable/SSTableWriter.java
+++ b/src/java/org/apache/cassandra/io/sstable/SSTableWriter.java
@@ -99,7 +99,7 @@ public class SSTableWriter extends SSTable
             dbuilder = SegmentedFile.getCompressedBuilder();
             dataFile = CompressedSequentialWriter.open(getFilename(),
                                                        \
                descriptor.filenameFor(Component.COMPRESSION_INFO),
-                                                       \
!DatabaseDescriptor.populateIOCacheOnFlush(), +                                       \
                !metadata.populateIoCacheOnFlush(),
                                                        \
                metadata.compressionParameters(),
                                                        sstableMetadataCollector);
         }
@@ -107,7 +107,7 @@ public class SSTableWriter extends SSTable
         {
             dbuilder = \
SegmentedFile.getBuilder(DatabaseDescriptor.getDiskAccessMode());  dataFile = \
                SequentialWriter.open(new File(getFilename()),
-			                      !DatabaseDescriptor.populateIOCacheOnFlush());
+			                      !metadata.populateIoCacheOnFlush());
             integratyWriter = DataIntegrityMetadata.checksumWriter(descriptor);
             dataFile.setDataIntegratyWriter(integratyWriter);
         }
@@ -406,7 +406,7 @@ public class SSTableWriter extends SSTable
         IndexWriter(long keyCount)
         {
             indexFile = SequentialWriter.open(new \
                File(descriptor.filenameFor(SSTable.COMPONENT_INDEX)),
-                                              \
!DatabaseDescriptor.populateIOCacheOnFlush()); +                                      \
                !metadata.populateIoCacheOnFlush());
             builder = \
                SegmentedFile.getBuilder(DatabaseDescriptor.getIndexAccessMode());
             summary = new IndexSummary(keyCount, metadata.getIndexInterval());
             bf = FilterFactory.getFilter(keyCount, \
metadata.getBloomFilterFpChance(), true);

http://git-wip-us.apache.org/repos/asf/cassandra/blob/22f515b3/src/resources/org/apache/cassandra/cli/CliHelp.yaml
                
----------------------------------------------------------------------
diff --git a/src/resources/org/apache/cassandra/cli/CliHelp.yaml \
b/src/resources/org/apache/cassandra/cli/CliHelp.yaml index d811663..3d4bd99 100644
--- a/src/resources/org/apache/cassandra/cli/CliHelp.yaml
+++ b/src/resources/org/apache/cassandra/cli/CliHelp.yaml
@@ -544,6 +544,9 @@ commands:
         - replicate_on_write: Replicate every counter update from the leader to the
         follower replicas. Accepts the values true and false.
 
+        - populate_io_cache_on_flush: Populates the page cache on memtable flush
+        and compaction. Accepts the values true and false.
+
         - compression_options: Options related to compression.
           Options have the form {key:value}.
           The main recognized options are:
@@ -834,6 +837,9 @@ commands:
         - replicate_on_write: Replicate every counter update from the leader to the
         follower replicas. Accepts the values true and false.
 
+        - populate_io_cache_on_flush: Populates the page cache on memtable flush
+        and compaction. Accepts the values true and false.
+
         - compression_options: Options related to compression.
           Options have the form {key:value}.
           The main recognized options are:


[prev in list] [next in list] [prev in thread] [next in thread]