[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    D15428: [textlayout] Don't enter infinite loop when table is misfit
From:       Dag Andersen <noreply () phabricator ! kde ! org>
Date:       2019-01-17 6:40:11
Message-ID: aaae2a6f2cd4dc603091fc16d75f7839 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

danders added a comment.


  Ran this patch against new unit tests and it fixes all the expected ones, namely \
those where all cells in first row is merged with cells in second row.  Test results \
without patch: https://build.kde.org/job/Calligra/job/calligra/job/kf5-qt5%20SUSEQt5.1 \
0/lastCompletedBuild/testReport/projectroot.libs.textlayout/tests/libs_kotextlayout_TestTableLayout
  See uploaded file for result with patch.F6552719: LastTest.log \
<https://phabricator.kde.org/F6552719>

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever


[Attachment #3 (text/html)]

<table><tr><td style="">danders added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15428">View Revision</a></tr></table><br \
/><div><div><p>Ran this patch against new unit tests and it fixes all the expected \
ones, namely those where all cells in first row is merged with cells in second \
row.<br /> Test results without patch: <a \
href="https://build.kde.org/job/Calligra/job/calligra/job/kf5-qt5%20SUSEQt5.10/lastCom \
pletedBuild/testReport/projectroot.libs.textlayout/tests/libs_kotextlayout_TestTableLayout" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://build.kde.org/job/Calligra/job/calligra/job/kf5-qt5%20SUSEQt5 \
.10/lastCompletedBuild/testReport/projectroot.libs.textlayout/tests/libs_kotextlayout_TestTableLayout</a><br \
/> See uploaded file for result with patch.<a \
href="https://phabricator.kde.org/F6552719" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">F6552719: \
LastTest.log</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R8 \
Calligra</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15428">https://phabricator.kde.org/D15428</a></div></div><br \
/><div><strong>To: </strong>anthonyfieroni, Calligra: 3.0, danders, boemann<br \
/><strong>Cc: </strong>Calligra-Devel-list, dcaliste, cochise, vandenoever<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]