[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-mac
Subject: Re: Review Request 129804: [Mac] enable app icon generation from the SVG icon (potentially for MS Wi
From: René J.V. Bertin <rjvbertin () gmail ! com>
Date: 2017-01-14 19:19:07
Message-ID: 20170114191907.32006.15711 () mimi ! kde ! org
[Download RAW message or body]
--===============3152592946761109172==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129804/
-----------------------------------------------------------
(Updated Jan. 14, 2017, 8:19 p.m.)
Review request for Calligra and KDE Software on Mac OS X.
Changes
-------
Give calligraworkplan an app icon too.
Repository: calligra
Description
-------
Hinted at in my previous RR: this patch concern the generation of app icons on Mac \
and potentially on MS Windows.
Several points:
- The `iconutils` utility is limited or incorrectly invoked by `ecm_add_app_icon`, \
leading to errors on OS X 10.9 when using PNG files larger than \
256x256px .
- `ecm_add_app_icon` takes care of copying the icon (.icns) file into the app bundle; \
no need to install it explicitly
- a recent change I committed to the ECM allows `ecm_add_app_icon` to accept an SVG \
(or SVGz) file, and will create the app icon using that file if the `ksvg2icns` \
utility is available (provided by KIconThemes so it should always be available).
I hope that this modification will be released with ECM 5.30.0 . The ECM being what \
they are there should be no issue requiring its latest version, but the changes in \
the present patch will be transparent with older ECM versions (except for warnings \
about ignoring unsupported icon source files).
There is an equivalent `svg2ico` utility in the KDEWin project which also provides a \
`png2ico` implementation. I plan to propose an updated version for inclusion with \
KIconThemes. That would allow feature parity for `ecm_add_app_icon` on MSWin, but I \
would need someone else to test it (I don't have a MSWin dev system).
Diffs (updated)
-----
braindump/src/CMakeLists.txt 95e0772
flow/part/CMakeLists.txt f5d0893
gemini/CMakeLists.txt c8713d6
karbon/CMakeLists.txt ba775ad
plan/CMakeLists.txt 25427da
plan/workpackage/CMakeLists.txt ec50d6d
sheets/CMakeLists.txt 0256de5
stage/app/CMakeLists.txt b5b4464
words/app/CMakeLists.txt 8cf0157
Diff: https://git.reviewboard.kde.org/r/129804/diff/
Testing
-------
tested on Mac and Linux with Qt 5.7.1 and FWs 5.29.0 , currently only for Karbon and \
Words.
Thanks,
René J.V. Bertin
--===============3152592946761109172==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129804/">https://git.reviewboard.kde.org/r/129804/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Calligra and KDE Software on Mac OS X.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Jan. 14, 2017, 8:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Give calligraworkplan an app icon too.</p></pre> \
</td> </tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hinted at in my previous RR: this patch concern the \
generation of app icons on Mac and potentially on MS Windows.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Several points:</p> <ul style="padding: 0;text-rendering: inherit;margin: 0 \
0 0 1em;line-height: inherit;white-space: normal;"> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">The \
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">iconutils</code> utility is limited or \
incorrectly invoked by <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">ecm_add_app_icon</code>, \
leading to errors on OS X 10.9 when using PNG files larger than 256x256px . </li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">ecm_add_app_icon</code> takes care of copying \
the icon (.icns) file into the app bundle; no need to install it explicitly</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">a recent change I committed to the ECM allows <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">ecm_add_app_icon</code> to accept an SVG (or SVGz) file, and will create \
the app icon using that file if the <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">ksvg2icns</code> utility is available (provided by KIconThemes so it should \
always be available).</li> </ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I hope that this modification will be released with \
ECM 5.30.0 . The ECM being what they are there should be no issue requiring its \
latest version, but the changes in the present patch will be transparent with older \
ECM versions (except for warnings about ignoring unsupported icon source files).</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">There is an equivalent <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">svg2ico</code> utility in the KDEWin project which also provides a <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">png2ico</code> implementation. I plan to propose an updated \
version for inclusion with KIconThemes. That would allow feature parity for <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">ecm_add_app_icon</code> on MSWin, but I would need someone \
else to test it (I don't have a MSWin dev system).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">tested on Mac and Linux with Qt 5.7.1 and FWs 5.29.0 , \
currently only for Karbon and Words.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>braindump/src/CMakeLists.txt <span style="color: grey">(95e0772)</span></li>
<li>flow/part/CMakeLists.txt <span style="color: grey">(f5d0893)</span></li>
<li>gemini/CMakeLists.txt <span style="color: grey">(c8713d6)</span></li>
<li>karbon/CMakeLists.txt <span style="color: grey">(ba775ad)</span></li>
<li>plan/CMakeLists.txt <span style="color: grey">(25427da)</span></li>
<li>plan/workpackage/CMakeLists.txt <span style="color: grey">(ec50d6d)</span></li>
<li>sheets/CMakeLists.txt <span style="color: grey">(0256de5)</span></li>
<li>stage/app/CMakeLists.txt <span style="color: grey">(b5b4464)</span></li>
<li>words/app/CMakeLists.txt <span style="color: grey">(8cf0157)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129804/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3152592946761109172==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic