[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 129512: [stencil] Follow system color for stencilsdocker icons
From:       Dag Andersen <danders () get2net ! dk>
Date:       2016-11-25 7:36:53
Message-ID: 20161125073653.11805.90234 () mimi ! kde ! org
[Download RAW message or body]

--===============0032559874811276318==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129512/#review101106
-----------------------------------------------------------


Ship it!




Ship It!

- Dag Andersen


On Nov. 21, 2016, 4:54 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129512/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2016, 4:54 a.m.)
> 
> 
> Review request for Calligra and Camilla Boemann.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Still has icons who are drown incorrect, i blame factory, but need more invetigates.
> 
> 
> Diffs
> -----
> 
> plugins/stencilsdocker/CMakeLists.txt 43a4e3c 
> plugins/stencilsdocker/StencilBoxDocker.cpp 3e4da8c 
> 
> Diff: https://git.reviewboard.kde.org/r/129512/diff/
> 
> 
> Testing
> -------
> 
> Build and run with Karbon.
> PS: Email me if you notice any other downsides :)
> 
> 
> File Attachments
> ----------------
> 
> White theme
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/20/74f03c72-491f-478e-a082-9c5e3e072999__Screenshot_20161120_213518.png
>  Black theme
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/20/b96331ae-db38-455f-a715-50101c30a3d0__Screenshot_20161120_213613.png
>  
> 
> Thanks,
> 
> Anthony Fieroni
> 
> 


--===============0032559874811276318==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129512/">https://git.reviewboard.kde.org/r/129512/</a>
     </td>
    </tr>
   </table>
   <br />



<p>

Ship it!

</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />









<p>- Dag Andersen</p>


<br />
<p>On November 21st, 2016, 4:54 a.m. UTC, Anthony Fieroni wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Calligra and Camilla Boemann.</div>
<div>By Anthony Fieroni.</div>


<p style="color: grey;"><i>Updated Nov. 21, 2016, 4:54 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Still has icons who are drown incorrect, i \
blame factory, but need more invetigates.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
                inherit;margin: 0;line-height: inherit;white-space: inherit;">Build and run with Karbon.
PS: Email me if you notice any other downsides :)</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plugins/stencilsdocker/CMakeLists.txt <span style="color: grey">(43a4e3c)</span></li>

 <li>plugins/stencilsdocker/StencilBoxDocker.cpp <span style="color: grey">(3e4da8c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129512/diff/" style="margin-left: 3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/11/20/74f03c72-491f-478e-a082-9c5e3e072999__Screenshot_20161120_213518.png">White \
theme</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/11/20/b96331ae-db38-455f-a715-50101c30a3d0__Screenshot_20161120_213613.png">Black \
theme</a></li>

</ul>




  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============0032559874811276318==--


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic