'Re: Review Request 126553: Fix GHNS build.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 126553: Fix GHNS build.
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2015-12-30 6:19:03
Message-ID: 20151230061903.18086.64581 () mimi ! kde ! org
[Download RAW message or body]

--===============4258329084065233648==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126553/#review90324
-----------------------------------------------------------

Ship it!

I'm sure the change is fine, though I recommend everyone to build with GHNS disabled \
because it's too broken to be useful. Can you push the change yourself?

- Boudewijn Rempt

On Dec. 28, 2015, 9:58 p.m., Matthew Dawson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126553/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 9:58 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This allows calligra to build when GHNS is enabled.
> 
> 
> Diffs
> -----
> 
> krita/ui/widgets/kis_advanced_color_space_selector.cc 4d40b1f 
> libs/widgets/CMakeLists.txt c9a84e7 
> 
> Diff: https://git.reviewboard.kde.org/r/126553/diff/
> 
> 
> Testing
> -------
> 
> Code now compiles.
> 
> 
> Thanks,
> 
> Matthew Dawson
> 
> 

--===============4258329084065233648==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126553/">https://git.reviewboard.kde.org/r/126553/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
sure the change is fine, though I recommend everyone to build with GHNS disabled \
because it's too broken to be useful. Can you push the change yourself?</p></pre>  \
<br />

<p>- Boudewijn Rempt</p>

<br />
<p>On December 28th, 2015, 9:58 p.m. UTC, Matthew Dawson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Matthew Dawson.</div>

<p style="color: grey;"><i>Updated Dec. 28, 2015, 9:58 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This allows calligra to build when GHNS is \
enabled.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Code now compiles.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>krita/ui/widgets/kis_advanced_color_space_selector.cc <span style="color: \
grey">(4d40b1f)</span></li>

 <li>libs/widgets/CMakeLists.txt <span style="color: grey">(c9a84e7)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126553/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4258329084065233648==--

[Attachment #3 (text/plain)]

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 