'Re: Review Request 123039: Porting of KReport to Qt5/KF5'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 123039: Porting of KReport to Qt5/KF5
From:       "Inge Wallin" <inge () lysator ! liu ! se>
Date:       2015-03-18 20:36:09
Message-ID: 20150318203609.15053.20129 () mimi ! kde ! org
[Download RAW message or body]

--===============1293698133610674049==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123039/#review77706
-----------------------------------------------------------

Er, why id you attach the diff file instead of uploading the diff into the review \
request like is normally done?

- Inge Wallin

On March 18, 2015, 7:34 p.m., Adam Pigg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123039/
> -----------------------------------------------------------
> 
> (Updated March 18, 2015, 7:34 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> In-development porting of KReport to standalone library
> 
> Borrows some files from calligra to allow building.
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://git.reviewboard.kde.org/r/123039/diff/
> 
> 
> Testing
> -------
> 
> None
> 
> It builds!
> 
> 
> File Attachments
> ----------------
> 
> Current Diff
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/18/01b20ee8-7884-46c3-a776-e22fb27dc1ba__kreport.diff
>  
> 
> Thanks,
> 
> Adam Pigg
> 
> 

--===============1293698133610674049==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123039/">https://git.reviewboard.kde.org/r/123039/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Er, \
why id you attach the diff file instead of uploading the diff into the review request \
like is normally done?</p></pre>  <br />

<p>- Inge Wallin</p>

<br />
<p>On March 18th, 2015, 7:34 p.m. CET, Adam Pigg wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Adam Pigg.</div>

<p style="color: grey;"><i>Updated March 18, 2015, 7:34 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In-development porting of KReport to standalone \
library</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Borrows some files from calligra to allow \
building.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">None</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">It builds!</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123039/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/18/01b20ee8-7884-46c3-a776-e22fb27dc1ba__kreport.diff">Current \
Diff</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1293698133610674049==--

[Attachment #3 (text/plain)]

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 