[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Review Request 122946: Krita - Move labels into the sliders, make them dpi dependent
From:       "Moritz Molch" <kde () moritzmolch ! de>
Date:       2015-03-14 13:55:45
Message-ID: 20150314135545.27069.84693 () mimi ! kde ! org
[Download RAW message or body]

--===============9142623424820732829==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122946/
-----------------------------------------------------------

Review request for Calligra.


Repository: calligra


Description
-------

This patch moves the labels into the sliders in the main UI and makes the minimal \
width dpi dependent to give them a reasonable size on high resolution screens. It \
also fixes the "two line issue" in the sliders.

The slider labels can be disabled by adding the line
sliderLabels=false
to the config at the moment.

It is good UI design to have elements that belong together also visually grouped \
together because it's easier for the eyes to parse, so it makes perfectly sense \
(that's also one of the reasons why gimp, blender and lots of other applications are \
doing this, it's not really about saving space)


Diffs
-----

  krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp db1728c 
  krita/ui/kis_config.h 31cc94d 
  krita/ui/kis_config.cc 27dca2d 
  krita/ui/kis_paintop_box.cc b1135d7 
  krita/ui/widgets/kis_cmb_composite.cc 9d54f74 
  krita/ui/widgets/kis_slider_spin_box.h 4ce641a 
  krita/ui/widgets/kis_slider_spin_box.cpp 59f6b78 
  krita/ui/widgets/kis_widget_chooser.h 5f7528b 
  krita/ui/widgets/kis_widget_chooser.cpp 3a699a8 

Diff: https://git.reviewboard.kde.org/r/122946/diff/


Testing
-------

Tested on Ubuntu 14.04


Thanks,

Moritz Molch


--===============9142623424820732829==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122946/">https://git.reviewboard.kde.org/r/122946/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Moritz Molch.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch moves the labels into the sliders in the \
main UI and makes the minimal width dpi dependent to give them a reasonable size on \
high resolution screens. It also fixes the "two line issue" in the sliders.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The slider labels can be disabled by adding the line sliderLabels=false
to the config at the moment.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It is good UI design to have elements that belong \
together also visually grouped together because it's easier for the eyes to parse, so \
it makes perfectly sense (that's also one of the reasons why gimp, blender and lots \
of other applications are doing this, it's not really about saving space)</p></pre>  \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested on Ubuntu 14.04</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp <span \
style="color: grey">(db1728c)</span></li>

 <li>krita/ui/kis_config.h <span style="color: grey">(31cc94d)</span></li>

 <li>krita/ui/kis_config.cc <span style="color: grey">(27dca2d)</span></li>

 <li>krita/ui/kis_paintop_box.cc <span style="color: grey">(b1135d7)</span></li>

 <li>krita/ui/widgets/kis_cmb_composite.cc <span style="color: \
grey">(9d54f74)</span></li>

 <li>krita/ui/widgets/kis_slider_spin_box.h <span style="color: \
grey">(4ce641a)</span></li>

 <li>krita/ui/widgets/kis_slider_spin_box.cpp <span style="color: \
grey">(59f6b78)</span></li>

 <li>krita/ui/widgets/kis_widget_chooser.h <span style="color: \
grey">(5f7528b)</span></li>

 <li>krita/ui/widgets/kis_widget_chooser.cpp <span style="color: \
grey">(3a699a8)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122946/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============9142623424820732829==--


[Attachment #3 (text/plain)]

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic