--===============5639739968915843104== Content-Type: multipart/alternative; boundary="===============1800750415127060724==" --===============1800750415127060724== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122546/ ----------------------------------------------------------- (Updated Март 1, 2015, 6:04 п.п.) Review request for Calligra, Camilla Boemann and Inge Wallin. Repository: calligra Description ------- List of changes: //Global 1) New KoRDFBasicSemanticItem was extracted from KoRDFSemanticItem. Basic version doesn't have notifications, custom representation in text and so on. 2) Changed allwhere rdf urls to appropriate ones according to new newest openDocument standard 3) KoSection now handles inline rdf link 4) Many formatting fixes and minor fixes in many places: a) Structre to "delete-on-quit" in KoTextDrag replaced with QScoperPointer b) Minor bag in KoSectionManager sectionAtPostion() function c) Some old FIXMEs fixed Sorry for not placing some of above fixing stuff to another branch :( //Author 5) Extracted CAuDocument to embed all author-related functionality like covers 6) Author has now own base class for semantics items, and CAuMetaDataManager stores all of them properly in separate file in package (author.rdf), properly handling links from main document according to RDF storing standards. 7) There is now only two semantic items for Section and Actor (in meaning of Author metadata). Now outliner is hidden (theres is comment where this docker is registred) (it isn't finished by now). There are a lot of changes allwhere, so the list above is too short. There were a big mess with rdf before (especially with prefix naming). I want to apply this changes in merge window to port them to Qt5. Diffs (updated) ----- libs/kotext/KoTextDrag.cpp 03f9020 libs/kotext/KoTextInlineRdf.h f367ae0 libs/kotext/KoTextInlineRdf.cpp 3ecccf6 libs/kotext/KoTextRdfCore.cpp d5d152c libs/rdf/CMakeLists.txt d62d464 libs/rdf/InsertSemanticObjectReferenceAction.cpp d812659 libs/rdf/KoDocumentRdf.h caa6485 libs/rdf/KoDocumentRdf.cpp a7a093a libs/rdf/KoDocumentRdfEditWidget.h 53d0f86 libs/rdf/KoDocumentRdfEditWidget.cpp c094af1 libs/rdf/KoDocumentRdfEditWidget.ui 4dcdedb libs/rdf/KoRdfBasicSemanticItem.h PRE-CREATION libs/rdf/KoRdfBasicSemanticItem.cpp PRE-CREATION libs/rdf/KoRdfPrefixMapping.cpp 0d592d6 libs/rdf/KoRdfSemanticItem.h 7e8f955 libs/rdf/KoRdfSemanticItem.cpp 6d19e60 libs/rdf/KoRdfSemanticItemFactoryBase.h 002996d libs/rdf/KoRdfSemanticItemFactoryBase.cpp 52e35cd libs/rdf/KoRdfSemanticItemRegistry.h e64ca49 libs/rdf/KoRdfSemanticItemRegistry.cpp 362cc24 libs/rdf/KoRdfSemanticItem_p.h 0fb535e libs/rdf/KoRdfSemanticTree.cpp 7d67cc9 libs/rdf/KoSopranoTableModel.cpp 32f1002 libs/rdf/RdfForward.h b27dd8d libs/rdf/tests/TestSemanticItem.h 5f015fd libs/rdf/tests/rdf_test.cpp 55ee566 plugins/semanticitems/authorsection/CMakeLists.txt PRE-CREATION plugins/semanticitems/contact/KoContactSemanticItemFactory.h 3108047 plugins/semanticitems/contact/KoContactSemanticItemFactory.cpp a7cba13 plugins/semanticitems/contact/KoRdfFoaF.cpp 01314a1 plugins/semanticitems/event/KoEventSemanticItemFactory.h ed529c0 plugins/semanticitems/event/KoEventSemanticItemFactory.cpp c1f191f plugins/semanticitems/event/KoRdfCalendarEvent.cpp cf8e6fe plugins/semanticitems/location/KoLocationSemanticItemFactory.h 8ce9d5e plugins/semanticitems/location/KoLocationSemanticItemFactory.cpp 43d8368 plugins/semanticitems/location/KoRdfLocation.h 52cbba8 plugins/semanticitems/location/KoRdfLocation.cpp 5f88ab7 words/part/CMakeLists.txt bce2d47 words/part/KWDocument.h b6e5d9f words/part/KWDocument.cpp 91dd6cb words/part/KWOdfWriter.cpp d7fea2c filters/libodfreader/OdtReader.cpp 48e1037 libs/kotext/KoSection.h 82f4c75 libs/kotext/KoSection.cpp eb83b49 libs/kotext/KoSectionManager.cpp 4143ca8 words/part/KWView.h e49f287 words/part/KWView.cpp 9cb6b82 words/part/author/CAuDocument.h PRE-CREATION words/part/author/CAuDocument.cpp PRE-CREATION words/part/author/CAuFactory.cpp 07c482a words/part/author/CAuView.cpp d29ddc7 words/part/author/author.rc 7846861 words/part/author/dockers/CAuOutlinerDocker.h PRE-CREATION words/part/author/dockers/CAuOutlinerDocker.cpp PRE-CREATION words/part/author/dockers/CAuOutlinerDockerFactory.h PRE-CREATION words/part/author/dockers/CAuOutlinerDockerFactory.cpp PRE-CREATION words/part/author/dockers/CAuOutlinerWidget.h PRE-CREATION words/part/author/dockers/CAuOutlinerWidget.cpp PRE-CREATION words/part/author/metadata/CAuActorRdf.h PRE-CREATION words/part/author/metadata/CAuActorRdf.cpp PRE-CREATION words/part/author/metadata/CAuActorRdfEditWidget.ui PRE-CREATION words/part/author/metadata/CAuActorSemanticItemFactory.h PRE-CREATION words/part/author/metadata/CAuActorSemanticItemFactory.cpp PRE-CREATION words/part/author/metadata/CAuMetaDataManager.h PRE-CREATION words/part/author/metadata/CAuMetaDataManager.cpp PRE-CREATION words/part/author/metadata/CAuSectionRdf.h PRE-CREATION words/part/author/metadata/CAuSectionRdf.cpp PRE-CREATION words/part/author/metadata/CAuSectionRdfEditWidget.ui PRE-CREATION words/part/author/metadata/CAuSectionSemanticItemFactory.h PRE-CREATION words/part/author/metadata/CAuSectionSemanticItemFactory.cpp PRE-CREATION words/part/author/metadata/CAuSemanticItemBase.h PRE-CREATION words/part/author/metadata/CAuSemanticItemBase.cpp PRE-CREATION words/part/dockers/KWDebugWidget.h ed483f0 words/part/dockers/KWDebugWidget.cpp 6b3bc7b words/part/dockers/KWNavigationWidget.cpp 71268a4 words/part/dockers/KWRdfDocker.h 9ad179a words/part/dockers/KWRdfDocker.cpp 5129fbe words/part/tests/TestRdf.cpp 4017415 Diff: https://git.reviewboard.kde.org/r/122546/diff/ Testing ------- I were testing while outliner docker was enabled, saving metadata for sections is working (opening, closing). You can check RDF with File-Document Information-Rdf. Thanks, Denis Kuplyakov --===============1800750415127060724== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122546/

Review request for Calligra, Camilla Boemann and Inge Wallin.
By Denis Kuplyakov.

Updated Март 1, 2015, 6:04 п.п.

Repository: calligra

Description 

List of changes:


//Global
1) New KoRDFBasicSemanticItem was extracted from KoRDFSemanticItem. Basic version doesn't have notifications, custom representation in text and so on.
2) Changed allwhere rdf urls to appropriate ones according to new newest openDocument standard
3) KoSection now handles inline rdf link
4) Many formatting fixes and minor fixes in many places:
  a) Structre to "delete-on-quit" in KoTextDrag replaced with QScoperPointer
  b) Minor bag in KoSectionManager sectionAtPostion() function
  c) Some old FIXMEs fixed


Sorry for not placing some of above fixing stuff to another branch :(


//Author
5) Extracted CAuDocument to embed all author-related functionality like covers
6) Author has now own base class for semantics items, and CAuMetaDataManager stores all of them properly in separate file in package (author.rdf), properly handling links from main document according to RDF storing standards.
7) There is now only two semantic items for Section and Actor (in meaning of Author metadata).


Now outliner is hidden (theres is comment where this docker is registred) (it isn't finished by now).


There are a lot of changes allwhere, so the list above is too short. There were a big mess with rdf before (especially with prefix naming). I want to apply this changes in merge window to port them to Qt5.

Testing 

I were testing while outliner docker was enabled, saving metadata for sections is working (opening, closing). You can check RDF with File-Document Information-Rdf.

Diffs (updated)

  • libs/kotext/KoTextDrag.cpp (03f9020)
  • libs/kotext/KoTextInlineRdf.h (f367ae0)
  • libs/kotext/KoTextInlineRdf.cpp (3ecccf6)
  • libs/kotext/KoTextRdfCore.cpp (d5d152c)
  • libs/rdf/CMakeLists.txt (d62d464)
  • libs/rdf/InsertSemanticObjectReferenceAction.cpp (d812659)
  • libs/rdf/KoDocumentRdf.h (caa6485)
  • libs/rdf/KoDocumentRdf.cpp (a7a093a)
  • libs/rdf/KoDocumentRdfEditWidget.h (53d0f86)
  • libs/rdf/KoDocumentRdfEditWidget.cpp (c094af1)
  • libs/rdf/KoDocumentRdfEditWidget.ui (4dcdedb)
  • libs/rdf/KoRdfBasicSemanticItem.h (PRE-CREATION)
  • libs/rdf/KoRdfBasicSemanticItem.cpp (PRE-CREATION)
  • libs/rdf/KoRdfPrefixMapping.cpp (0d592d6)
  • libs/rdf/KoRdfSemanticItem.h (7e8f955)
  • libs/rdf/KoRdfSemanticItem.cpp (6d19e60)
  • libs/rdf/KoRdfSemanticItemFactoryBase.h (002996d)
  • libs/rdf/KoRdfSemanticItemFactoryBase.cpp (52e35cd)
  • libs/rdf/KoRdfSemanticItemRegistry.h (e64ca49)
  • libs/rdf/KoRdfSemanticItemRegistry.cpp (362cc24)
  • libs/rdf/KoRdfSemanticItem_p.h (0fb535e)
  • libs/rdf/KoRdfSemanticTree.cpp (7d67cc9)
  • libs/rdf/KoSopranoTableModel.cpp (32f1002)
  • libs/rdf/RdfForward.h (b27dd8d)
  • libs/rdf/tests/TestSemanticItem.h (5f015fd)
  • libs/rdf/tests/rdf_test.cpp (55ee566)
  • plugins/semanticitems/authorsection/CMakeLists.txt (PRE-CREATION)
  • plugins/semanticitems/contact/KoContactSemanticItemFactory.h (3108047)
  • plugins/semanticitems/contact/KoContactSemanticItemFactory.cpp (a7cba13)
  • plugins/semanticitems/contact/KoRdfFoaF.cpp (01314a1)
  • plugins/semanticitems/event/KoEventSemanticItemFactory.h (ed529c0)
  • plugins/semanticitems/event/KoEventSemanticItemFactory.cpp (c1f191f)
  • plugins/semanticitems/event/KoRdfCalendarEvent.cpp (cf8e6fe)
  • plugins/semanticitems/location/KoLocationSemanticItemFactory.h (8ce9d5e)
  • plugins/semanticitems/location/KoLocationSemanticItemFactory.cpp (43d8368)
  • plugins/semanticitems/location/KoRdfLocation.h (52cbba8)
  • plugins/semanticitems/location/KoRdfLocation.cpp (5f88ab7)
  • words/part/CMakeLists.txt (bce2d47)
  • words/part/KWDocument.h (b6e5d9f)
  • words/part/KWDocument.cpp (91dd6cb)
  • words/part/KWOdfWriter.cpp (d7fea2c)
  • filters/libodfreader/OdtReader.cpp (48e1037)
  • libs/kotext/KoSection.h (82f4c75)
  • libs/kotext/KoSection.cpp (eb83b49)
  • libs/kotext/KoSectionManager.cpp (4143ca8)
  • words/part/KWView.h (e49f287)
  • words/part/KWView.cpp (9cb6b82)
  • words/part/author/CAuDocument.h (PRE-CREATION)
  • words/part/author/CAuDocument.cpp (PRE-CREATION)
  • words/part/author/CAuFactory.cpp (07c482a)
  • words/part/author/CAuView.cpp (d29ddc7)
  • words/part/author/author.rc (7846861)
  • words/part/author/dockers/CAuOutlinerDocker.h (PRE-CREATION)
  • words/part/author/dockers/CAuOutlinerDocker.cpp (PRE-CREATION)
  • words/part/author/dockers/CAuOutlinerDockerFactory.h (PRE-CREATION)
  • words/part/author/dockers/CAuOutlinerDockerFactory.cpp (PRE-CREATION)
  • words/part/author/dockers/CAuOutlinerWidget.h (PRE-CREATION)
  • words/part/author/dockers/CAuOutlinerWidget.cpp (PRE-CREATION)
  • words/part/author/metadata/CAuActorRdf.h (PRE-CREATION)
  • words/part/author/metadata/CAuActorRdf.cpp (PRE-CREATION)
  • words/part/author/metadata/CAuActorRdfEditWidget.ui (PRE-CREATION)
  • words/part/author/metadata/CAuActorSemanticItemFactory.h (PRE-CREATION)
  • words/part/author/metadata/CAuActorSemanticItemFactory.cpp (PRE-CREATION)
  • words/part/author/metadata/CAuMetaDataManager.h (PRE-CREATION)
  • words/part/author/metadata/CAuMetaDataManager.cpp (PRE-CREATION)
  • words/part/author/metadata/CAuSectionRdf.h (PRE-CREATION)
  • words/part/author/metadata/CAuSectionRdf.cpp (PRE-CREATION)
  • words/part/author/metadata/CAuSectionRdfEditWidget.ui (PRE-CREATION)
  • words/part/author/metadata/CAuSectionSemanticItemFactory.h (PRE-CREATION)
  • words/part/author/metadata/CAuSectionSemanticItemFactory.cpp (PRE-CREATION)
  • words/part/author/metadata/CAuSemanticItemBase.h (PRE-CREATION)
  • words/part/author/metadata/CAuSemanticItemBase.cpp (PRE-CREATION)
  • words/part/dockers/KWDebugWidget.h (ed483f0)
  • words/part/dockers/KWDebugWidget.cpp (6b3bc7b)
  • words/part/dockers/KWNavigationWidget.cpp (71268a4)
  • words/part/dockers/KWRdfDocker.h (9ad179a)
  • words/part/dockers/KWRdfDocker.cpp (5129fbe)
  • words/part/tests/TestRdf.cpp (4017415)

View Diff
--===============1800750415127060724==-- --===============5639739968915843104== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KY2FsbGlncmEt ZGV2ZWwgbWFpbGluZyBsaXN0CmNhbGxpZ3JhLWRldmVsQGtkZS5vcmcKaHR0cHM6Ly9tYWlsLmtk ZS5vcmcvbWFpbG1hbi9saXN0aW5mby9jYWxsaWdyYS1kZXZlbAo= --===============5639739968915843104==--