[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 120940: Added parsing of hashtag comments inside imported csv in kexi
From: Jarosław_Staniek <staniek () kde ! org>
Date: 2015-02-27 23:29:02
Message-ID: 20150227232902.12883.89170 () probe ! kde ! org
[Download RAW message or body]
--===============9037380865160777333==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Feb. 28, 2015, 12:20 a.m., Jarosław Staniek wrote:
> > Looks good!
> > Please fix minor things.
PS: after pusing it, this could be added if you want: \
https://todo.kde.org/?controller=task&action=show&task_id=970
- Jarosław
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120940/#review76749
-----------------------------------------------------------
On Feb. 26, 2015, 11:02 p.m., Wojciech Kosowicz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120940/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 11:02 p.m.)
>
>
> Review request for Calligra, Adam Pigg and Jarosław Staniek.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> When hash sign (#) appears in csv file at the beginning of the line or in the \
> middle of unqouted field it is treated as the beginning of the comment and the \
> following data is being ignored until the end of the row
>
> Diffs
> -----
>
> kexi/plugins/importexport/csv/kexicsvimportdialog.h 3dc3fe4
> kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 6572285
> kexi/plugins/importexport/csv/kexicsvwidgets.h 1e87dbd
> kexi/plugins/importexport/csv/kexicsvwidgets.cpp 3cf6ea4
> libs/widgets/KoCsvImportDialog.cpp 8d042d7
>
> Diff: https://git.reviewboard.kde.org/r/120940/diff/
>
>
> Testing
> -------
>
> Able to activate/deactivate parsing comments. When activated able to choose \
> specific sign
>
> Thanks,
>
> Wojciech Kosowicz
>
>
--===============9037380865160777333==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120940/">https://git.reviewboard.kde.org/r/120940/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 28th, 2015, 12:20 a.m. CET, \
<b>Jarosław Staniek</b> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks good! Please fix \
minor things.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">PS: \
after pusing it, this could be added if you want: \
https://todo.kde.org/?controller=task&action=show&task_id=970</p></pre> <br \
/>
<p>- Jarosław</p>
<br />
<p>On February 26th, 2015, 11:02 p.m. CET, Wojciech Kosowicz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Calligra, Adam Pigg and Jarosław Staniek.</div>
<div>By Wojciech Kosowicz.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2015, 11:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When hash sign (#) appears in csv file at the \
beginning of the line or in the middle of unqouted field it is treated as the \
beginning of the comment and the following data is being ignored until the end of the \
row</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Able to activate/deactivate parsing comments. When \
activated able to choose specific sign</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/plugins/importexport/csv/kexicsvimportdialog.h <span style="color: \
grey">(3dc3fe4)</span></li>
<li>kexi/plugins/importexport/csv/kexicsvimportdialog.cpp <span style="color: \
grey">(6572285)</span></li>
<li>kexi/plugins/importexport/csv/kexicsvwidgets.h <span style="color: \
grey">(1e87dbd)</span></li>
<li>kexi/plugins/importexport/csv/kexicsvwidgets.cpp <span style="color: \
grey">(3cf6ea4)</span></li>
<li>libs/widgets/KoCsvImportDialog.cpp <span style="color: \
grey">(8d042d7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120940/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============9037380865160777333==--
[Attachment #3 (text/plain)]
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic