[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 122559: Kexi. Display message for the query export when its design is "dirty".
From: Jarosław_Staniek <staniek () kde ! org>
Date: 2015-02-27 22:33:31
Message-ID: 20150227223331.12883.14410 () probe ! kde ! org
[Download RAW message or body]
--===============6989445242447693529==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122559/#review76748
-----------------------------------------------------------
Ship it!
Great!
kexi/main/KexiMainWindow.h
<https://git.reviewboard.kde.org/r/122559/#comment52832>
add one row of space
- Jarosław Staniek
On Feb. 27, 2015, 5:56 p.m., Roman Shtemberko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122559/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 5:56 p.m.)
>
>
> Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, and \
> Wojciech Kosowicz.
>
> Repository: calligra
>
>
> Description
> -------
>
> Message is being displayed If design of query being exported is dirty. Also window \
> with query is opened (without switching views) on export.
>
> Diffs
> -----
>
> kexi/core/KexiMainWindowIface.h 7255d57
> kexi/core/kexipart.h e320434
> kexi/core/kexipart.cpp ca70942
> kexi/main/KexiMainWindow.h 3b2814f
> kexi/main/KexiMainWindow.cpp 8d45408
> kexi/migration/importtablewizard.cpp 964d365
> kexi/plugins/importexport/csv/CMakeLists.txt 9d40ce6
> kexi/plugins/importexport/csv/kexicsvexport.h 280b33f
> kexi/plugins/importexport/csv/kexicsvexport.cpp 50af810
> kexi/plugins/importexport/csv/kexicsvexportwizard.cpp 096ea71
> kexi/plugins/queries/kexiquerypart.h 09491f5
> kexi/plugins/queries/kexiquerypart.cpp ce7548e
>
> Diff: https://git.reviewboard.kde.org/r/122559/diff/
>
>
> Testing
> -------
>
> Work with both exports (to file/clipboard).
>
>
> Thanks,
>
> Roman Shtemberko
>
>
--===============6989445242447693529==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122559/">https://git.reviewboard.kde.org/r/122559/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Great!</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122559/diff/4-5/?file=350264#file350264line229" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kexi/main/KexiMainWindow.h</a> <span style="font-weight: normal;">
(Diff revisions 4 - 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public \
slots:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">227</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="cm">/*! \
Implemented for KexiMainWindowIface. */</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">229</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="cm">/*! \
Implemented for KexiMainWindowIface. */</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">add \
one row of space</p></pre> </div>
</div>
<br />
<p>- Jarosław Staniek</p>
<br />
<p>On February 27th, 2015, 5:56 p.m. CET, Roman Shtemberko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, and \
Wojciech Kosowicz.</div> <div>By Roman Shtemberko.</div>
<p style="color: grey;"><i>Updated Feb. 27, 2015, 5:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Message is being displayed If design of query being \
exported is dirty. Also window with query is opened (without switching views) on \
export.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Work with both exports (to file/clipboard).</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/core/KexiMainWindowIface.h <span style="color: grey">(7255d57)</span></li>
<li>kexi/core/kexipart.h <span style="color: grey">(e320434)</span></li>
<li>kexi/core/kexipart.cpp <span style="color: grey">(ca70942)</span></li>
<li>kexi/main/KexiMainWindow.h <span style="color: grey">(3b2814f)</span></li>
<li>kexi/main/KexiMainWindow.cpp <span style="color: grey">(8d45408)</span></li>
<li>kexi/migration/importtablewizard.cpp <span style="color: \
grey">(964d365)</span></li>
<li>kexi/plugins/importexport/csv/CMakeLists.txt <span style="color: \
grey">(9d40ce6)</span></li>
<li>kexi/plugins/importexport/csv/kexicsvexport.h <span style="color: \
grey">(280b33f)</span></li>
<li>kexi/plugins/importexport/csv/kexicsvexport.cpp <span style="color: \
grey">(50af810)</span></li>
<li>kexi/plugins/importexport/csv/kexicsvexportwizard.cpp <span style="color: \
grey">(096ea71)</span></li>
<li>kexi/plugins/queries/kexiquerypart.h <span style="color: \
grey">(09491f5)</span></li>
<li>kexi/plugins/queries/kexiquerypart.cpp <span style="color: \
grey">(ce7548e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122559/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6989445242447693529==--
[Attachment #3 (text/plain)]
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic