[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2015-02-25 9:18:19
Message-ID: alpine.LNX.2.00.1502251017290.6677 () calcifer ! valdyas ! org
[Download RAW message or body]

On Wed, 25 Feb 2015, C. Boemann wrote:

> On Wednesday 25 February 2015 10:01:16 Boudewijn Rempt wrote:
>> > Applying full astyle is IMHO not OK, and even against efforts of
>> > everyone who keeps eye on proper coding style while doing code
>> > reviews.
>> 
>> Sorry, our current code base is a mess. I don't care about kexi, and I 
>> won't touch kexi. I won't touch any library except for pigment. But the 
>> mess we have with bracket placing, include styles, spaces around function 
>> arguments, initializer lists... It just needs cleaning up.
> I'm not against cleaning up coding style, but any such commit should follow 
> what we are practicing already, and not some half broken astyle. I have no 
> idea what astyle does and doesn't do, but i will not accept commits away from 
> our qt/kde style.
>
> so show me that it doesn't mess up please
>

Check David's notes in kde-dev-scripts, please. That's what I was 
referring to. And sure I'll be careful.

Boudewijn
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread]