'Re: Review Request 122306: Fix bug 260088 - assert when ungrouping group'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 122306: Fix bug 260088 - assert when ungrouping group
From:       "Inge Wallin" <inge () lysator ! liu ! se>
Date:       2015-01-29 15:33:02
Message-ID: 20150129153302.13680.42639 () probe ! kde ! org
[Download RAW message or body]

--===============5568805373518877316==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122306/
-----------------------------------------------------------

(Updated Jan. 29, 2015, 4:33 p.m.)

Status
------

This change has been marked as submitted.

Review request for Calligra, Elvis Stansvik and Camilla Boemann.

Repository: calligra

Description
-------

This patch makes Words not crash anymore.

But it's not the full solution because after the ungrouping the shapes behave very \
strange when you select them and try to use "Shape properties" in the context menu. I \
thought I'd show this crash fix first, though and then estan can fix the strange \
behaviour since it's in his new code.

Diffs
-----

  words/part/KWView.cpp f20199a 

Diff: https://git.reviewboard.kde.org/r/122306/diff/

Testing
-------

manual testing according to the bug report.

Thanks,

Inge Wallin

--===============5568805373518877316==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122306/">https://git.reviewboard.kde.org/r/122306/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Calligra, Elvis Stansvik and Camilla Boemann.</div>
<div>By Inge Wallin.</div>

<p style="color: grey;"><i>Updated Jan. 29, 2015, 4:33 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch makes Words not crash anymore.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">But it's not the full solution because after the ungrouping the shapes \
behave very strange when you select them and try to use "Shape properties" in the \
context menu. I thought I'd show this crash fix first, though and then estan can fix \
the strange behaviour since it's in his new code.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">manual testing according to the bug report.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>words/part/KWView.cpp <span style="color: grey">(f20199a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122306/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5568805373518877316==--

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 