[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving t
From: "Inge Wallin" <inge () lysator ! liu ! se>
Date: 2015-01-27 10:10:41
Message-ID: 20150127101041.30682.8761 () probe ! kde ! org
[Download RAW message or body]
--===============6245312401317896781==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122266/#review74821
-----------------------------------------------------------
Ship it!
Ok, all of my questions have been answered so I'm satisfied.
- Inge Wallin
On Jan. 27, 2015, 10:48 a.m., Camilla Boemann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122266/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2015, 10:48 a.m.)
>
>
> Review request for Calligra.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> split kwrootareaprovider in 3 classes for better overview and solving text flwing \
> between textboxes
>
> Diffs
> -----
>
> words/part/frames/KWTextFrameSet.cpp c8ccdb9
> words/part/KWRootAreaProviderBase.cpp PRE-CREATION
> words/part/KWRootAreaProviderTextBox.h PRE-CREATION
> words/part/KWRootAreaProviderTextBox.cpp PRE-CREATION
> words/part/frames/KWFrame.cpp f88f902
> words/part/frames/KWTextFrameSet.h 9106758
> words/part/CMakeLists.txt 386431e
> words/part/KWRootAreaProvider.h 54deaf3
> words/part/KWRootAreaProvider.cpp d26f519
> words/part/KWRootAreaProviderBase.h PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/122266/diff/
>
>
> Testing
> -------
>
> ran cstester and did some manual testing, but should eally do it again
>
>
> Thanks,
>
> Camilla Boemann
>
>
--===============6245312401317896781==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122266/">https://git.reviewboard.kde.org/r/122266/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok, \
all of my questions have been answered so I'm satisfied.</p></pre> <br />
<p>- Inge Wallin</p>
<br />
<p>On January 27th, 2015, 10:48 a.m. CET, Camilla Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Camilla Boemann.</div>
<p style="color: grey;"><i>Updated Jan. 27, 2015, 10:48 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">split kwrootareaprovider in 3 classes for better \
overview and solving text flwing between textboxes</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">ran cstester and did some manual testing, but should \
eally do it again</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>words/part/frames/KWTextFrameSet.cpp <span style="color: \
grey">(c8ccdb9)</span></li>
<li>words/part/KWRootAreaProviderBase.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>words/part/KWRootAreaProviderTextBox.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>words/part/KWRootAreaProviderTextBox.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>words/part/frames/KWFrame.cpp <span style="color: grey">(f88f902)</span></li>
<li>words/part/frames/KWTextFrameSet.h <span style="color: \
grey">(9106758)</span></li>
<li>words/part/CMakeLists.txt <span style="color: grey">(386431e)</span></li>
<li>words/part/KWRootAreaProvider.h <span style="color: grey">(54deaf3)</span></li>
<li>words/part/KWRootAreaProvider.cpp <span style="color: \
grey">(d26f519)</span></li>
<li>words/part/KWRootAreaProviderBase.h <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122266/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6245312401317896781==--
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic