'Re: Review Request 122254: Remove inline objects from manager in DeleteCommand'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 122254: Remove inline objects from manager in DeleteCommand
From:       "Elvis Stansvik" <elvstone () gmail ! com>
Date:       2015-01-25 23:07:18
Message-ID: 20150125230718.30683.28219 () probe ! kde ! org
[Download RAW message or body]

--===============2253051580104357043==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122254/
-----------------------------------------------------------

(Updated Jan. 25, 2015, 11:07 p.m.)

Status
------

This change has been marked as submitted.

Review request for Calligra, Camilla Boemann and Inge Wallin.

Bugs: 303492
    http://bugs.kde.org/show_bug.cgi?id=303492

Repository: calligra

Description
-------

This patch makes sure that the text editor's DeleteCommand removes inline objects \
from the KoInlineTextObjectManager when the user removes them.

With the patch applied, end notes are correctly removed when you remove their \
reference in the main text. It thus fixes bug #303492.

The reason I'm putting it up for review is that:

1. I'm not 100% sure the fix is correct.
2. I'm still confused as to why it seemingly works to remove foot notes at the \
moment, and not end notes. It would seem to me it shouldn't work for either of them.

Diffs
-----

  libs/kotext/commands/DeleteCommand.h f6faad2 
  libs/kotext/commands/DeleteCommand.cpp 7c69df7 

Diff: https://git.reviewboard.kde.org/r/122254/diff/

Testing
-------

I tested adding/removing footnotes and endnotes in various places, and removing them \
by backspacing/deleting across their references, or selecting a bunch of references \
with the mouse and hitting backspace/delete. Both footnotes and endnotes were removed \
from the bottom of the page/document.

Thanks,

Elvis Stansvik

--===============2253051580104357043==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122254/">https://git.reviewboard.kde.org/r/122254/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Calligra, Camilla Boemann and Inge Wallin.</div>
<div>By Elvis Stansvik.</div>

<p style="color: grey;"><i>Updated Jan. 25, 2015, 11:07 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=303492">303492</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch makes sure that the text editor's \
DeleteCommand removes inline objects from the KoInlineTextObjectManager when the user \
removes them.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">With the patch applied, end notes are correctly \
removed when you remove their reference in the main text. It thus fixes bug \
#303492.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The reason I'm putting it up for review is that:</p> \
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">I'm not 100% sure the fix is \
correct.</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">I'm still confused as to why it seemingly works to \
remove foot notes at the moment, and not end notes. It would seem to me it shouldn't \
work for either of them.</li> </ol></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I tested adding/removing footnotes and endnotes in \
various places, and removing them by backspacing/deleting across their references, or \
selecting a bunch of references with the mouse and hitting backspace/delete. Both \
footnotes and endnotes were removed from the bottom of the page/document.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/kotext/commands/DeleteCommand.h <span style="color: \
grey">(f6faad2)</span></li>

 <li>libs/kotext/commands/DeleteCommand.cpp <span style="color: \
grey">(7c69df7)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122254/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2253051580104357043==--

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 