[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 110928: Always save the position of a shape
From: "Inge Wallin" <inge () lysator ! liu ! se>
Date: 2015-01-15 6:07:35
Message-ID: 20150115060735.19346.8463 () probe ! kde ! org
[Download RAW message or body]
--===============6990832718699458123==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On July 6, 2014, 4:51 p.m., Camilla Boemann wrote:
> > After having read the discussion I come out on the side of dismissing, based on \
> > the following:
> > 1) It is not done as a result of a bug
> > 2) It produces more output xml
> > 3) The spec states what default values are, and we try not to write out default \
> > values in other cases.
>
> Inge Wallin wrote:
> 1. I don't remember anymore how relevant this was to the bug mentioned in the \
> description, but I will look at it again and come back. 2. That is irrelevant since \
> the amount is very small. 3. This might be a good point. I will look at it again. \
> One possible reason to do it anyway would be for compatibility with other, faulty, \
> ODF consumers but I don't know if that is actually an issue.
> Boudewijn Rempt wrote:
> Ping again? Is still still WIP, or to be discarded?
I have investigated this again. It seems that without svg:x and svg:y older versions \
of LibreOffice do not load this file but say that it is corrupt. A newer version I \
tried does indeed load it. I didn't make any investigations about where it started to \
load it. LibreOffice does save svg:x and svg:y even if they are 0. So if we want to \
keep compatibility with older versions of LibreOffice we need to apply it.
It would be interesting to see what OpenOffice.org but I am fairly certain that it \
behaves like older LibreOffice versions.
I cannot see a single downside with applying the patch.
- Inge
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110928/#review61727
-----------------------------------------------------------
On June 10, 2013, 9:18 p.m., Inge Wallin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110928/
> -----------------------------------------------------------
>
> (Updated June 10, 2013, 9:18 p.m.)
>
>
> Review request for Calligra.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> When a shape is in the position 0, 0 and there are no other transformations, the \
> position will not be saved back. In other words, there will be an svg:height and \
> svg:width but no svg:x or svg:y. I noticed this while trying to fix \
> https://bugs.kde.org/show_bug.cgi?id=184727.
> This patch fixes that the code doesn't save the position. I suggest that we apply \
> it to 2.7 as well and maybe also to 2.6.
>
> Diffs
> -----
>
> libs/flake/KoShape.cpp 6d14a8c
>
> Diff: https://git.reviewboard.kde.org/r/110928/diff/
>
>
> Testing
> -------
>
> Tested with the file mentioned above.
>
>
> Thanks,
>
> Inge Wallin
>
>
--===============6990832718699458123==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/110928/">https://git.reviewboard.kde.org/r/110928/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 6th, 2014, 4:51 p.m. CEST, <b>Camilla \
Boemann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">After having read the discussion I come out on the \
side of dismissing, based on the following:</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">1) It is not done as a \
result of a bug 2) It produces more output xml
3) The spec states what default values are, and we try not to write out default \
values in other cases.</p></pre> </blockquote>
<p>On July 6th, 2014, 5:56 p.m. CEST, <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ol style="padding: \
0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: \
normal;"> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">I don't remember anymore how relevant this was to the \
bug mentioned in the description, but I will look at it again and come back.</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">That is irrelevant since the amount is very small.</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">This \
might be a good point. I will look at it again. One possible reason to do it anyway \
would be for compatibility with other, faulty, ODF consumers but I don't know if that \
is actually an issue.</li> </ol></pre>
</blockquote>
<p>On October 15th, 2014, 6:55 p.m. CEST, <b>Boudewijn Rempt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ping \
again? Is still still WIP, or to be discarded?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
have investigated this again. It seems that without svg:x and svg:y older versions of \
LibreOffice do not load this file but say that it is corrupt. A newer version I tried \
does indeed load it. I didn't make any investigations about where it started to load \
it. LibreOffice does save svg:x and svg:y even if they are 0. So if we want to keep \
compatibility with older versions of LibreOffice we need to apply it.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">It would be interesting to see what OpenOffice.org but I am fairly certain \
that it behaves like older LibreOffice versions.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
cannot see a single downside with applying the patch.</p></pre> <br />
<p>- Inge</p>
<br />
<p>On June 10th, 2013, 9:18 p.m. CEST, Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated June 10, 2013, 9:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When a shape is in the position 0, 0 and there are no other \
transformations, the position will not be saved back. In other words, there will be \
an svg:height and svg:width but no svg:x or svg:y. I noticed this while trying to \
fix https://bugs.kde.org/show_bug.cgi?id=184727.
This patch fixes that the code doesn't save the position. I suggest that we \
apply it to 2.7 as well and maybe also to 2.6.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with the file mentioned above.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoShape.cpp <span style="color: grey">(6d14a8c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/110928/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6990832718699458123==--
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic